New Features and Changes (since RHQ 4.10 )

Known Issues

Deprecations

Newly deprecated since 4.10:

Deprecated since 4.9:

• bin/internal/rhq-storage-installer.sh switch -dbpassword was deprecated. Use -encodepassword instead. NOTE: use this only if you want to obtain obfuscated version of your password for automatization. Because normally user is asked for the password in terminal.

Deprecated since 4.8:

• REST-API Endpoints introduced in 4.5.1 to create platforms and resources have been deprecated - replacements are provided.
  The deprecated endpoints will go away in RHQ 4.11

Bundles:

• Constructor org.rhq.bundle.ant.AntLauncher#AntLauncher() has been deprecated. Callers should switch to using a new constructor org.rhq.bundle.ant.AntLauncher#AntLauncher(boolean requireExplicitCompliance).

• Method org.rhq.bundle.ant.type.DeploymentUnitType#getManageRootDir() has been deprecated. Callers should switch to using a new method org.rhq.bundle.ant.type.DeploymentUnitType#getCompliance() method.

• Method org.rhq.bundle.ant.type.DeploymentUnitType#setManageRootDir(String booleanString) has been deprecated. Callers should switch to using a new method org.rhq.bundle.ant.type.DeploymentUnitType#setCompliance(org.rhq.core.util.updater.DestinationComplianceMode) method.

• Constructor org.rhq.core.util.updater.DeploymentData#DeploymentData(DeploymentProperties deploymentProps, Set zipFiles, Map rawFiles, File sourceDir, File destinationDir, Map zipEntriesToRealizeRegex, Set rawFilesToRealize, TemplateEngine templateEngine, Pattern ignoreRegex, boolean manageRootDir, Map zipsExploded) has been deprecated. Callers should switch to using a new constructor org.rhq.core.util.updater.DeploymentData#DeploymentData(DeploymentProperties deploymentProps, Set zipFiles, Map rawFiles, File sourceDir, File destinationDir, Map zipEntriesToRealizeRegex, Set rawFilesToRealize, TemplateEngine templateEngine, Pattern ignoreRegex, Map zipsExploded) this is because the manageRootDir parameter is deprecated and this constructor should not be used. The need for that parameter was superseded by the org.rhq.core.util.updater.DeploymentProperties#getDestinationCompliance().

• Method org.rhq.core.util.updater.DeploymentData#isManageRootDir() has been deprecated. Callers should switch to using a new method org.rhq.core.util.updater.DeploymentProperties#getDestinationCompliance() method.

• Constructor org.rhq.core.util.updater.DeploymentProperties#DeploymentProperties(int deploymentId, String bundleName, String bundleVersion, String description) has been deprecated. Callers should switch to using a new constructor org.rhq.core.util.updater.DeploymentProperties#DeploymentProperties(int, String, String, String, DestinationComplianceMode).

• Method org.rhq.core.util.updater.DeploymentProperties#getManageRootDir() has been deprecated. Callers should switch to using a new method org.rhq.core.util.updater.DeploymentProperties#getDestinationCompliance() method.

• Method org.rhq.core.util.updater.DeploymentProperties#setManageRootDir(boolean willManageRootDir) has been deprecated. Callers should switch to using a new method org.rhq.core.util.updater.DeploymentProperties#setDestinationCompliance(DestinationComplianceMode mode) method.

Other:

• Method org.rhq.core.util.exec.ProcessExecutor#redirectStreams() has been deprecated. Callers should switch to using a new method org.rhq.core.util.exec.ProcessExecutor#redirectAllStreams() method.

• Method org.rhq.enterprise.server.resource.group.LdapGroupManagerBean#getProperties(Properties systemConfig) has been deprecated.

• Method org.rhq.core.domain.cloud.StorageNodeLoadComposite#getDiskSpacePercentageUsed() has been deprecated. Callers should switch to using a new method org.rhq.core.domain.cloud.StorageNodeLoadComposite#getPartitionDiskUsedPercentage() method.

• Method org.rhq.core.domain.cloud.StorageNodeLoadComposite#setDiskSpacePercentageUsed(MeasurementAggregateWithUnits diskUsedPercentage) has been deprecated. Callers should switch to using a new method org.rhq.core.domain.cloud.StorageNodeLoadComposite#setPartitionDiskUsedPercentage() method.

API changes

Translations

The GWT part of the UI has partially been translated into German, Portuguese, Japanese, Chinese, Czech, Russian and Korean. The language should be automatically selected depending on your browser settings. You can explicitly access other translations by appending a locale specifier in the URL. For example to select the German translation you would append ?locale=de to the base URL, e.g. http://localhost:7080/coregui/?locale=de.

Supported locales are:

• zh for Chinese

• cs for Czech

• de for German

• ja for Japanese

• pt for Portuguese

• ru for Russian

• ko for Korean

Please ping us if you want to help translating the UI to your language. Translations are done via the translations project on GitHub, which also has some instructions on how to start.

Bug reporting

Please report all bugs you find in Bugzilla. If you find a bug that has been recorded in the above list, please leave a comment on them especially if this needs special steps to reproduce.

Download

You can download the release here
A video of the install procedure can be found here

Docker

RHQ 4.11 is now also available as a Docker image. Check out this link for the image and information on how to use it on Fedora 20 or RHEL 6.5:

https://index.docker.io/u/gkhachik/rhq-fedora.20/
repo: gkhachik/rhq-fedora.20**
*tag: 4.11*

Commit log (since RHQ_4_10_0 )

• Heiko W. Rupp <hwr@redhat.com> (14):

  • Merge pull request #13 from lzoubek/bugs/958922

  • Merge pull request #5 from lzoubek/bugs/1069679

  • BZ_1080171 - defer adding of "WHERE" keyword until we know that it is needed.

  • Updated checks after comments from @metlos.

  • Add a missing colon in toString that was confusing

  • Bump required ems-version to one that we have forked and changed. Also add more tests. The forked ems is located at https://github.com/rhq-project/ems

  • Remove the accidentally introduced sub-module reference.

  • First cut of a Aerogear-Unified-Push-Server alert plugin.

  • Merge pull request #11 from lzoubek/feature/canned-expressions

  • Merge pull request #16 from lzoubek/bugs/1080909

  • Bump ems version to 1.3.5-rhq for lighter connection checking.

  • Some cleanup and externalization of settings.

  • Merge pull request #25 from pilhuhn/alert-ups

  • Fix a bad typo on the maven module name.

• Jay Shaughnessy <jshaughn@redhat.com> (36):

  • 1073201 Agent does a discovery loop if the inventory contains an unknown resource It's possible to disable a plugin on an agent after resources of that plugin's types are already in server-side inventory. The server will report those resources to the agent during an inventory sync. The agent will treat them as "unknown" resources because those resources will not have containers.

  • 1073201 Agent does a discovery loop if the inventory contains an unknown resource Patch supplied by <elias_ross@apple.com>. The patch worked around the issue although in a prior commit I put in a fix for the core issue. But the patch is also useful. I'm applying parts of it, manually, as applying it verbatim was not applicable after my initial change.

  • 1073201 revisions due to test failures - Go back to providing a full avail report if there are inventory sync changes. This isn't really that inefficient agent-side because it's not a full scan, but rather a full report. We still only check avail for those resources that have not yet provided avail, and the regularly scheduled checks. - Don't just skip a service scan if one is in progress. We should scan again from the top to guarantee nothing gets missed. So, instead, cancel the current scan and add interrupt logic such that it reports what it has discovered to that point. And then start a new scan. - update Discoverytest to explcitly wait for discovery to complete, the changes seem to have changed the dynamics of the test.

  • 1073201 revision due to regression When updating plugin config we added an optimization to root the ensuing service discovery at the resource being updated, as opposed to doing a full service scan. The regression resulted from passing the attached Resource to the agent. Never pass attached objects to the agent from the server. Unfortunately, detaching the object was not viable as it actually needed to stay attached for the overall logic flow. So, I lightened the API to just require the resourceId, which is a better agent API anyway.

  • 1079027 Storage Node (un)deployment can cause deadlock in rhq_storage_node table Initial commit that attempts to remove umbrella transactions starting at many entry points, such that scheduling operations happens in their own trans context. Needs review and testing...

  • Transaction delimiters have been updatedin StorageNode beans to try and prevent db-locking issues. This caused a problem for storage node deployment during mergeInventory, because it relied on an umbrella transaction providing a persisted (but not yet committed) Resource.

  • Make sure StorageNode is committed before we try and deploy it.

  • More changes to LinkStorageNode to try and get the transactioning right.

  • Since the Hibernate4 standard dialect resolver does not recognize Oracle 12, we need to ensure the hibernate.dialect system property is set when running the i-tests.

  • To support oracle 12c, updating the default driver version. It should be backward compatible to our earlier, supported releases.

  • 1079027 Storage Node (un)deployment can cause deadlock in rhq_storage_node table Fix issue with new transactioning that left some entity changes uncommitted.

  • Merge branch 'jshaughn/storage'

  • 668870 Replace Tanuki Java Service Wrapper with EAP native components to support 32-bit and 64-bit base architecture types - Update JSW with version 3.4.1 and add the 64-bit community version for distribution. - Update scripts to use the proper JSW version based on Win OS architecture and JVM architecture. - Update wrapper .conf and .inc files as needed. - add new server .conf java.additional prop required to prevent logger initialization problem between JSW and EAP. - update logfile loglevel to STATUS for all wrapper logging, this provides more useful logging for server and storage wrapper logs, and trims excessive logging in the agent wrapper log. - fixed numbering issue in dev-container server-wrapper.inc

  • Merge pull request #12 from Jiri-Kremser/bug1073096

  • 1065461 readOnly configuration is editable via CLI Update some jdoc to reflect that this is the expected behavior when calling from the CLI. read-only and other validation is applied only via the GUI's ConfigurationEditor.

  • 1060353 Non required or unused properties in rhq-server.properties are being required by rhqctl Make the unused oracle props optional and remove them from the supplied rhq-server.properties file.

  • 1061311 rhqctl contains user modifiable values that result in an unsupported rhqctl script Introduce rhq-server-env.bat. Analogous .sh file coming in subsequent commit.

  • 1060353 Non required or unused properties in rhq-server.properties are being required by rhqctl Remove some related special-case installer code.

  • 1061311 rhqctl contains user modifiable values that result in an unsupported rhqctl script Introduce rhq-server-env.sh. Now environment variables are set outside of the actual scripts used for installation, etc.

  • 1061311 rhqctl contains user modifiable values that result in an unsupported rhqctl script Add logic to 'rhqctl upgrade' command to copy rhq-server-env.sh|bat from the old to new server, if it exists. The old, potentially edited, version will be used and the new version will be backed up for reference in case it has new env variables and/or documentation. This behavior is analogous to what we currently do for rhq-agent-env.sh|bat during an agent update.

  • 1085270 Unable to install the RHQ server when calling rhqctl outside of bin directory Fallout from the changes made for 1061311. This updates the scripts in bin (notable rhqctl) to handle being executed from outside of bin, including as a symlink.

  • 1085270 Unable to install the RHQ server when calling rhqctl outside of bin directory Add back in the clipped '|| echo "$0"' segment of the directory-finding bit.

  • 1085270 Unable to install the RHQ server when calling rhqctl outside of bin directory Fallout from the changes made for 1061311. This updates the windows scripts in bin (notably rhqctl.bat) to handle being executed from outside of bin.

  • 1065461 readOnly configuration is editable via CLI Add a new signature to ConfigurationUtility.validateConfiguration that takes both a newConfiguration and currentConfiguration and ensure the new config does not alter any non-empty readOnly property value.

  • Fix test failures due to recent changes for bug 1065461.

  • 1085270 Unable to install the RHQ server when calling rhqctl outside of bin directory A fix for OS/X support. Also, move debug_msg up to match the way it is in rhqctl.

  • 798006 Drift detection hangs on reading named pipes on filesystem Protect against drift detection on not "normal" files.

  • Merge branch 'master' of github.com:rhq-project/rhq

  • 880359 JavaDoc used for Remote API is inconsistent with API I made another pass at the remote API jdoc, ensuring that all methods have at least minimal jdoc with the correct @param, @return, @throws, @deprecated and @since (starting with RHQ 4.5) annotations.

  • 1065461 readOnly configuration is editable via CLI - Fix a regression in List of Maps handling by relaxing size assumptions - on the old and new list entries. - Add equals checking for read-only Maps and Lists

  • 1065461 readOnly configuration is editable via CLI - an NPE fix to prior commit 1b551ae7671

  • Fix Oracle Schema issue. Constraint name max=30 chars.

  • 1061311 - rhqctl contains user modifiable values that result in an unsupported rhqctl script - Fix issues with rhq-encode-password.sh|bat - Don't abort a script if rhq-server-env.sh|bat is not found

  • 665508 rhq:url-archive, rhq:archive should support destinationFile/destinationDir Add "destinationDir" attribute for the archive targets. Note that it can only be used in conjunction with "exploded=false".

  • 665508 rhq:url-archive, rhq:archive should support destinationFile/destinationDir - Fix API back-compat issues in DeploymentData constructors - Fix ambiguous constructors issue in DeploymentData when using various null params - Fix some related jdoc - Update our code base to not use deprecated calls in DeploymentProperties and DeploymentData.

  • 1092975 Unable to update configuration of JBossAS7 Standalone Server Use the correct equality test for read-only PropertyList during config validation.

• Jirka Kremser <jkremser@redhat.com> (28):

  • irc-bot: commit link now points to the GitHub

  • BZ 1073096 ] - 'rhqctl -h install' tries to install the components instead of showing a help - Finding out whether user wants to just print a help. If it is the case, no warning ('An agent RPM installation was found...') with consequent 30s waiting is displayed.

  • BZ 1073096 ] - Adding the check for any unrecognized arguments.

  • BZ 1073096 ] - Simplifying the code: fail fast is --help option is present.

  • BZ 1073096 ] - The name of the command should not be part of the command's arguments. It worked in the previous implementation, because it ignored unrecognized options. But not now.

  • BZ 1073096 ] - When debugging the rhqctl code I came across to ConcurrentModificationException. Altought it is unlikely to happen in the production code without debuging, it is still posible -> making the copy of undoTasks, because other thread can modify it simultaneously.

  • BZ 1073096 ] - Showing unrecognized args

  • Setting the scope of SmartGWT dependency as provided, because it is needed only during the GWT compile time.

  • Running the stopwatch and logging the result only if debug lvl is set.

  • BZ 1069688 ] - (JON3-24) Add alert name filter to "Recent Alerts" dashboard portlet - Filtering now works for dashboard portlet (called "Recent Alerts") as well as for the "Summary/Activity" subtab portlet (called "Resource: Alerts" and "Group: Alerts")

  • BZ 1070243 ] - (JON3-31) Add "Recent Events" portlet into JON Dashboard

  • BZ 1081554 ] - Cannot load metrics error on a resource with no enabled metrics - Not performing the problematic DB query, when no metric on the resource is enabled. Also saving 2 (client-server)) round trips if the enabled metrics # equals to zero.

  • BZ 1069667 ] - (JON3-17) Make JON login look like other Red Hat products - First prototype. Using the PatternFly default logo.

  • BZ 1069667 ] - (JON3-17) Make JON login look like other Red Hat products - RHQ branding & handling error cases during login process.

  • BZ 1073096 ] - Adding "-h" as a valid help option to isHelp() method.

  • BZ 1069667 ] - Adding CAPS LOCK detection and version is now taken during the build time using mvn filtering.

  • BZ 1069667 ] - Handling the case with session expiration and the ability to redirect to the wanted page after successful login (#Bundles should open bundles view, not the default one which is #Dashboards)

  • BZ 1069667 ] - Better CAPS LOCK indication, the previous method didn't find out it the CAPS LOCK key was pressed during writing the password. It also didn't work when writing any numbers.

  • BZ 1069667 ] - Fixing the login page for LDAP registration and LDAP login.

  • BZ 1070243 & BZ 1069688] - Adding a button for resetting the

    filters. Also the "Filter by time" component is now more intuitive that it is has been turned on/off.

  • api checks: adding (un)installAgent methods is intentional non-breaking change

  • Merge pull request #21 from lzoubek/bugs/1080971

  • Using the maven-war-plugin instead of maven-resources-plugin for filtering the login page (for replacing the "${project.version}" with the project version).

  • Hiding the Resource Ancestry column in

    Portlets not to overwhelm user with bazillion columns. It can be shown if necessary. Also fixing a typo that caused to displayed Group Events Portlet instead of Alert Group Portlet.

  • BZ 1089789 ] - Login Broken for GWT Dev Mode - Fixing the new login page for GWT development mode.

  • Adding new

    monkey script for the new login page. Also adding the exclude pattern for the old one not to conflict with the new script. Now, both scripts can live together and the right one will be used with the corresponding RHQ version. Based on the fact that new login page uses "login" substring in the url.

  • BZ 1020807 ] - UI shows successful message even though an update of configuration failed - Changing the message from "Configuration updated..." to "Updating configuration...", because we cannot predict if the configuration update will or will not be successful.

  • api checks: adding RemoteInstallManagerRemote.checkSSHConnection() method as intentional non-breaking change

• John Mazzitelli <mazz@redhat.com> (30):

  • Merge pull request #3 from burmanm/BZ994250

  • BZ 1070242 - get remote agent install into non-RHQ product builds. had to upgrade jsch version to fix a bug that manifested itself as "verify: false" errors that only occurred sometimes. Apparently was a known issue and is fixed in jsch 0.1.51

  • BZ 823965 Maintain existing agent-configuration.xml and log4j.xml files after agent auto-update. The new configuration will be kept in agent-configuration.xml.new and log4j.xml.new so that we at least provide the user with the updated defaults in case they want to manually merge them.

  • fix script when rhq_agent_debug is on

  • BZ 1070242 - installating, starting, stopping, uninstalling agents on remote machines via SSH

  • fix typo - this is a linux script, not windows... ext is "sh" not "bat"

  • fix typo - extension is "sh" not "bat"

  • don't always show this message, make it a debug message

  • opps, need to move the debug_msg function up top

  • BZ 1030082 1029384 - shutdown the server if it was decommissioned (that is, its server entry was removed from the server table)

  • BZ 1080508 - make sure we set log level so the install doesn't abort

  • BZ 1045496 - have installer be able to recover from a canceled install if its aborted while the EAR is being deployed.

  • Merge branch 'bug/1076104' of https://github.com/metlos/rhq into metlos-bug/1076104

  • BZ 1076104 - remove bad import

  • BZ 1076104 consistent indentation in this file is 4 spaces

  • BZ 1089062 - get this to work on Solaris

  • BZ 1083557 - remove $() syntax to support solaris 10 and other OSes and shells that don't support it (Bourne Shell for example)

  • fix comment/message - this is the linux script - refer to .sh not .bat

  • BZ 1083557 - remove $() syntax to support solaris 10 and other OSes

  • BZ 1090453 - try to see if we can make a low level TCP connection to the agent after it has been installed - this helps detect if its behind a firewall and can't be reached by the server

  • BZ 1090829 - see if the port is already in use. If the port is in use, not only will this abort if another agent was installed, but it will abort if anything has taken the port the agent wants to use.

  • BZ 1090453 - internal api change

  • BZ 1091409 - right now, we don't support custom env files. To prohibit people from setting one, all setters and fields are private. If we support this in the future, we set these back to public and there are a couple places in the GUI code where we need to uncomment some lines that set the env file.

  • BZ 1091015 - be able to delete agent even if it doesn't exist on the file system

  • BZ 1091339 - validate the port field properly

  • BZ 1090476 - do not check for status if the agent wasn't found. this makes the UI more responsive. There is no need to check status anyway since we don't know where the agent is

  • BZ 1090448 - make the remote agent install UI more pretty

  • BZ 1090448 - this got munged - need to encode in UTF-8.

  • BZ 1091172 - get remote API to work with remote agent install

  • Squashed commit of the following:

• John Sanda <jsanda@redhat.com> (2):

  • BZ 1084626 ] Make sure metrics thread pool has more than 1 thread to avoid deadlock

  • BZ 1084626 ] adding constraint to ensure there are at least 2 aggregation worker threads

• Libor Zoubek <lzoubek@redhat.com> (17):

  • BZ 958922 ] RFE: support for passing plugin config when creating child resources

  • BZ 1069679 ] Expose responseTime metric via rest

  • BZ 1070668 ] Incorrect default configuration of RHQDS resource

  • added new lines between methods

  • Merge pull request #14 from lzoubek/bugs/1070668

  • BZ 1082767 ] Group view does not display proper content when user reaches AutoGroup via URL

  • BZ 1076605 ] The link to Autocluster group alert definition is wrong

  • BZ 1072543 ] Unable to collect metrics from EAP 6 datasources when a system properties is used in configuration

  • BZ 1080909 ] DynaGroup expression evaluator is not strict when grouping by resource configuration property

  • BZ 1080971 ] JON throws "java.lang.OutOfMemoryError" if drift file sets are big

  • BZ 1088264 ] AvailabilityExecutor stops calling getAvailability() on ResourceComponent after it previously failed with exception

  • BZ 1076126 ] - RFE: Canned dynaGroup expressions provided by plugin

  • BZ 1076126 ] Update Group Definitions UI to show DGs from plugins

  • bump dbversion

  • got rid of TABs

  • BZ 1075875 ] remote API client version is 'undefined' when client is packaged as executable JAR

  • add systemInfoManager to lookupUtil

• Lukas Krejci <lkrejci@redhat.com> (9):

  • BZ 1076258 ] Fix classloader leak in as7 plugin

  • BZ 1076389 ] Jar-less plugin now deployed in one go, no need to wait for the next scan.

  • BZ 1076104 ] Agent plugins don't require explicit purge to disappear from DB.

  • BZ 1076104 ] Server plugins don't require explicit purge do disappear.

  • Fixing API breakage

  • Cleanup of itests to not influence each other when setting server identity and manipulating plugins.

  • Removed unused method from local SLSB and some small docs updates.

  • Merge remote-tracking branch 'origin/master' into bug/1076104

  • BZ 1076104 ] - Fix the itest failures in plugin purge tests.

• Lukas Krejci <metlos@users.noreply.github.com> (3):

  • Merge pull request #17 from pilhuhn/bz1080171

  • Merge pull request #20 from pilhuhn/bz_1033553_new-ems-version

  • Merge pull request #19 from lzoubek/bugs/1072543

• Michael Burman <yak@iki.fi> (5):

  • Uses a wrapper to catch the return value instead of the ExecuteException

  • Remove commented lines

  • Tabs hopefully removed now..

  • Throw exception if agentStatus returns value other than 0,1 or 3

  • Replaced remaining tabs with 4 spaces

• Mike Thompson <mithomps@redhat.com> (8):

  • BZ 1080472 - The unit in the new d3 charts is not refreshed correctly. Fix the bug that improperly calculates the units of measure on the Y-Axis and on Min Value of chart legend.

  • BZ 1080470 ] - The unit in the new d3 charts is not refreshed correctly.

  • BZ 1080470 ] The unit in the new d3 charts is not refreshed correctly. Adjust the YAxis over to accommodate large values due to scale changes

  • Bring Metrics LiveData significant digits format to be inline with other fields. There are cases when it is off because it is server defined not client defined as live data values are.

  • Change the revision on the javascript and css static resources to reflect 4.11 version from 4.10 version. This strategy enables long caching on static resources while enabling cache busting behaviour between revision # changes.

  • BZ 1089108 ] File Systems -> Free Space graph off by a factor of 1000. This was due to a recent bug fix introduced for BZ1080470.

  • BZ 1089108 ] File Systems -> Free Space graph off by a factor of 1000. Refactored to a much cleaner solution with no IF logic. Removed some dead code from Measurement helper classes.

  • BZ 1092507 ] Globally uncaught exception when selecting an area which doesn't contain data in unfolded graph. Zooming in on range of no data (NaN) causes the lowestValue to become null because there is no low value (there are no valid values at all). This scenario was solved by assigning the measurement definition UOM when no valid values are available.

• Stefan Negrea <snegrea@redhat.com> (3):

  • BZ 1075575 ] Update Cassandra to a version specially crafted to not print the superfluous warning about OpenJDK.

  • Revert Cassandra dependency update until Nexus repository is fixed.

  • BZ 1075575 ] Update Cassandra to a version specially crafted to not print the superfluous warning about OpenJDK.

• Thomas Heute <theute@gmail.com> (1):

  • Very useful typo correction

• Thomas Segismont <tsegismo@redhat.com> (5):

  • BZ 1077412 - Restart operation on EAP 5 resource doesn't return failure message when restart fails

  • BZ 1079361 - Postgres Plugin - Scheduling A New List Process Statistics Operation Fails

  • BZ 579810 - Collection of Postgres table metrics fails when the tables are not in the public schema

  • BZ 1079403 - Postgres Plugin - Table Vacuum Fails

  • BZ 1082747 - Postgres Plugin - An Invalid Server Configuration Status Should Not Be Stack Trace