This is the RHQ 4.13 release.
RHQ 4.13 update process has changed from previous versions. Follow the instructions given after the update command has been run, to complete the update of the storage node schema. If you're updating from older version than 4.12, please also check the instructions and notes given in the 4.12 release notes.
RHQ 4.13 is recommended with Java7, and also supports Java6.
Alerts have new status available to them, recovered. Recent alerts portlet and alerts report can now show if the alert has recovered and when that has happened. Also, both the recent alerts portlet as well as the reports interface have received new filtering options based on the alert's status.
There is now possibility to automatically run resource discovery after bundle deployment (behaviour can be customized in the bundle deployment wizard).
EAP/Wildfly patches are recognized as bundles and are deployable to AS7-plugin-based servers.
Drift detection will now check all the possible files for
Customizable UI - allowing to hide or to show certain subsystems from the UI (more info in the PR 145 or BZ 1160775).
PatternFly theme has been enhanced in several places
Support for resource upgrade callbacks - a feature similar to resource discovery callbacks added in RHQ 4.12. Resource upgrade callback allows plugins to influence resource upgrade results of other resource types. This is useful if a plugin that specializes other plugin and needs to influence the resource upgrade results detected by the "parent" plugin.
displayName attribute has been added to plugin descriptor schema, hence it's now possible to rename Resource Types.
New resource types for runtime queues and topic subscribers are introduced, supporting all operations and monitoring all metrics exposed by EAP. Because runtime queues can frequently appear and disappear, the Missing Resource Policy now makes it possible to auto-uninventory non-existant runtime-queues as required.
Bundle deployments to a domain now supported.
Support for patching EAP 6.2.0+ and Wildfly 8+ using bundle subsystem.
Datasource management has been made a lot easier. Now you can change parameters which do not require reload without disabling the service.
Storage node plugin now exports metrics from the Cassandra driver. Older internal duplicate metrics have been removed.
Large amount of bugs have been fixed in the postgres plugin.
Support for EMS Connection to an AS7, EAP6 or Wildfly 8 server.
To address issues with servers running out of disk space on storage nodes, snapshots are no longer part of the weekly scheduled job, and are disabled by default. When enabled, snapshots can now be copied to a different location with more available storage space. Server-side capability now exists to manage snapshots for the storage cluster. System settings have been introduced, which can be updated through the Storage Administration pages. Users can also enable and disable snapshot management of storage clusters, and set cron expressions to run management tasks regularly. See https://docs.jboss.org/author/display/RHQ/Backup+and+Restore
Rate limit is now calculated based on the amount of available storage nodes automatically. There's no longer another option to limit or start with different amount than the per storage node additions. Also, throttling was changed at the same time and instead of lowering the limit when a timeout occurs, we halve the limit temporarily and allow it to grow to its original value slowly. If such an event occurs, it is reported in the RHQ logs (it should not occur often, in that case the delta per storage node should be lowered or additional storage nodes installed).
Schema updates have changed from 4.12 and this means the update process has also changed. This allows easier upgrade of HA-installations.
It's now possible to move storage node datafiles from the storage node administration view. Note that in a single storage node configuration moving datafiles will temporarily move RHQ to a maintenance mode.
There are several updates to the underlying database handling. We remove more stale data from the database now to prevent growth, as well as do the removal operations in smaller batches to prevent lockups. Some views have also gotten improved queries or indexing.
You cannot use "rhqctl install --start" when installing. The RHQ Server fails to reload itself during the installation process when you do this. Instead, execute "install" separate from "start" - as an example: rhqctl install && rhqctl start
[BZ 1118411] ERROR message logged during storage schema upgrade should be INFO level
[BZ 1118445] Resource for metrics_index table needs to be removed from inventory as part of upgrade
BundleDestination.{g|s}etDestinationBaseDirectoryName() use {s|g}etDestinationSpecificationName instead.
ResourceTypeBundleConfiguration.setBundleConfiguration use the provided type-safe modification methods provided in the class instead.
ResourceTypeBundleConfiguration.getBundleDestinationBaseDirectories() use getBundleDestinationSpecifications instead.
ResourceTypeBundleConfiguration.addBundleDestinationBaseDirectory(String, String, String, String) use addBundleDestinationBaseDirectory(String, String, String, String, java.util.List)} instead.
BundleDeployRequest.{g|s}etAbsoluteDestinationDirectory() use {g|s}etDestinationTarget() instead.
BundlePurgeRequest.{g|s}etAbsoluteDestinationDirectory() use {g|s}etDestinationTarget() instead.
BundleManagerBean.createBundleVersion() use one of the create(Initial)BundleVersionVia* methods instead.
MeasurementOOBComposite.setData use setDataMin(double) and setDataMax(double) instead.
WebConnectorComponent in as7 plugin, you can use the BaseComponent instead.
PostgresServerComponent.getObjectProperty() in Postgres plugin.
...and some constants for named queries on domain objects, but it shouldn't hurt anyone.
The GWT part of the UI has partially been translated into German, Portuguese, Japanese, Chinese, Czech, Russian and Korean. The language should be automatically selected depending on your browser settings. You can explicitly access other translations by appending a locale specifier in the URL. For example to select the German translation you would append ?locale=de to the base URL, e.g. http://localhost:7080/coregui/?locale=de.
Supported locales are:
zh for Chinese partial
cs for Czech partial
de for German full
ja for Japanese full
pt for Portuguese partial
ko for Korean partial
Please ping us if you want to help translating the UI to your language. Translations are done via the translations project on GitHub, which also has some instructions on how to start.
Please report all bugs you find in Bugzilla. If you find a bug that has been recorded in the above list, please leave a comment on them especially if this needs special steps to reproduce.
Please consult Bugzilla with a target release of RHQ 4.12 for a list of resolved issues
RHQ 4.13 is now also available as a Docker image. Check out this link for the image and information on how to use it:
repo: https://registry.hub.docker.com/u/rhqproject/rhq-nodb/
Hosting by GitHub and Jekyll, we accept pull requests on gh-pages branch.
Big thanks go to Alan Santos, Andreas Veithen, Elias Ross and Jérémie Lagarde for their contributions
Alan Santos <alan@poke53281.com> (9):
updated check boxes to follow patternfly theme
Update table Filter/Header to better reflect patternfly l&f See - https://www.patternfly.org/widgets/#data-tables
Merge branch 'master' of git://github.com/rhq-project/rhq into patternflyTable
Changes to button structure with an added icon throw off the CSS selector for primary and destructive buttons. PFly has no notion of images in buttons, so removing the images fixes the color
Added missing files. I suspect most of these aren't ever used, just automatically loaded, but can't see where.
Merge branch 'master' of git://github.com/rhq-project/rhq into checkBoxes
Merge branch 'master' of git://github.com/rhq-project/rhq into checkBoxes
Change ResourceTitleBar badge icon to use the 'TYPE' icon rather than an 'UP' icon
Replacing Header Icons and fix spacing
Andreas Veithen <veithen@google.com> (1):
Ensure that the server and agent scripts propagate SIGTERM in foreground mode
Elias Ross <elias_ross@apple.com> (10):
BZ 1032192 - AlertCondition composite queries, query each column
BZ 1032192 - AlertCondition intentional API changes
BZ 1073093 Alert template query does not scale well
BZ 1144238 - update DataStax driver to latest 1.0.8 release
BZ 1145292 - Heap max size is variable, not trait
BZ 1130392 - Sigar cannot detect kernel thread names
BZ 1135136 - NPE in MySQL plugin when PID_FILE value not found in database
BZ 1130341 - Agent can be stuck waiting for startup
For timeout at startup, use 30 seconds (fixed)
Use NotProcessedException to indicate startup latch timed out
Heiko W. Rupp <hwr@redhat.com> (3):
BZ 1121975 - the 'sid' parameter is required. Mark it as such in docs.
Add Mike as developer.
BZ 991510 - Add method javadoc
Hudson <jboss-qa-internal@redhat.com> (2):
development RHQ_4.13.0-SNAPSHOT
tag RHQ_4_13_0
Jay Shaughnessy <jshaughn@redhat.com> (107):
Fix issue with upgrade task executing on oracle (or any db not returning an Integer for the ID field).
1070326 - (JON3-42) RFE: Allow AS7 deployments to provide version in the artifact name I'm an idiot. Fixing stupid regression.
Resolve various build issues surrounding byteman dependencies. I'm honestly not sure I've done the right things here, but basically consolidate the byteman and jdbctrace plugin on byteman 1.5.2, which is what we needed for apache-integration-test module. NOte that current byteman release is 2.2 so thisis still well behind and now uses some deprecated methods.
Bring Eclipse .classpath up to 4.13 specs.
1118091 RHQ Agent resources are not being auto-clustered in resource group due to their unique resource keys To enable good autoclustering of RHQ Agent resources across platforms the agent resource keys must be the same. In general each platform has at most one imported 'RHQ Agent' child resource and it is named the same as the platform (Actually the platform's resource key). In this case do not incorporate the agent name into the resource key. In that way we can have a generic static reskey for the agents, across platforms, while still maintaining unique agent names across all agents (an RHQ requirement). In the rare case that a platform has multiple agents deployed (typically a perftest scenario, but sometimes a production scenario) at most one agent will get assigned the static key, only the one whose name matches the parent. All others will get the predictable legacy keys we've used up to this point. So, in the vast majority of cases, we should see good auto-clustering of the rhq agents.
1115725 Operation history continues to grow unbound with no easy way to purge old history Add operation history purge to the data purge job. A new system setting is added with a default of 0 days, which means disabled. The db-upgrade will add the new setting, also set to 0=disabled so that upgrades don't automatically force an unexpected purge of operation history. Also: - cleaned up some I18N when adding the new properties, removing some duplicates, adding commented, missing translations, etc. Some touched files were only due to some remvals of deuplicate I18N properties. - added DatabaseType.getLimitClause() although in the end I didn't use it.
1111064 Some code changes to avoid a locking issue. Presumably the issue has to so with passing an attached entity to an asynchronous slsb method. A few things: - make sure we pass a deteched entity - notify the alert condition-cache prior to calling the storage operation hook - only call the storage operation hook for updates to existing history (not at operation schedule-time) - remove an unnecessary outer Tx on runClusterMaintenance - add some logging
revert testing change to StorageClusterReadRepairJob, put it back to the original schedule.
Merge pull request #90 from rhq-project/jshaughn/1111064
1120417 Break up transaction of updatePluginConfigurationDefinition into smaller pieces Another round of scalability enhancements for updating plugin metadata. In the past we broke the update of each Plugin into its own Tx. Later we split registeringTypes and removingTypes into separate Tx and applied a 30 minute timeout to the type registration. With this pass we now update each type in its own Tx and allow up to 30 minutes per type. This can be necessary if updating plugin configurations for a large existing resource population.
1121220 Plugins with large description text for measurement def. cause ORA-12899 as far as I know we don't have a general mechanism for truncating on max length constraints. So this is just a point solution for this BZ. Before storing to the DB, ensure length constraints are met.
Fix dependency build issue
Merge pull request #86 from rhq-project/jshaughn/1118091
749368 add @since Javadoc tags to our public APIs Went through our intentional-changes files and added agfew missing @since tags that seemed maybe useful. I had previously updated the server's SLSB remote API, just added 4.12 for that.
1119262 jon3-7 EAP6 drifts exclude pattern not working for windows case The issue here is that the drift template defines the plugin descriptor and in this case, the associated excludes filter: pattern="_history//". It can only be predefined in one format, and the plugin naturally uses linux-style forward slashes for the directory separator.
1119781 runtime name provided for deployment child creation overrides application name and path Use the deploymentName as appropriate, the runtimeName should be an attribute on the deployment and can be the same on multiple deployments, the deploymentName must be unique among deployments.
1118394 deployment of new war from repo content fails This is not a fix for the reported issue, which actually seems to not be a bug. This is a fix to ensure failed package installs persist the error messageto the history record in the DB. And to provide a more useful log message in the agent log.
801432, 807465 Related Issue to these BZs Uninventory triggered our "assert-style" debug logging indicating that we were working with HashSet for child resources when we expected to be using a safer Set impl (wrt preventing ConcurrentModoficationException). There were a few issues in play: - When loading persisted resources from disk convert childResources to CopyOnWriteArraySet if necessary. This repairs resources persisted with the wrong Set impl. - Eliminate some potential concurrent modification danger (or, at a minimum, - Fix a couple of other places where we weren't using CopyOnWriteArraySet - Fix Resource entity to ensure that when customChildResourcesCollection=true that the childResources Set is truly protected. It was here that we were losing the proper Set impl. some unnecessary work) by only calling deactivateResource() on the root resource. It recursively deactivates the subtree, so no need to then call it on every node in the subtree. - Fix our "assert-logging" conditional, which despite finding this issue was actually looking for the wrong set impl. It had not been updated when we moved to CopyOnWriteArraySet.
1120417 Break up transaction of updatePluginConfigurationDefinition into smaller pieces Another pass here given some oracle test failures in the CI env. - Fix an issue with PropertyDefinitionSimple.removeEnumeratedValues. An unexpected problem brought out, I guess, by the Tx reworking, must be careful not to replace hibernate proxy dealing with orphanRemoval. - remove unnecessary REQUIRES_NEW that could lead to locking issues - remove some dead code - start shortening xxxInNewTransaction to xxxInNewTx, purely for selfish reasons.
In a recent commit for 1120417 (and the resulting oracle test failures) we added protection against Hibernate errors related to detached sets when orphanRemoval=true. This applies similar changes to entity classes outside of the BZ work.
1118061 Standalone or host server discovery throws warning every 15 minutes Converted to debug level logging
1119127 rhqctl to prompt for rhqadmin password, rather than using hard-coded default We no longer support the default rhqadmin/rhqadmin user/password superuser combination. The rhqadmin user still exists but the password must be set by the user. The new rhq.autoinstall.server.admin.password property must be set in rhq-server.properties. If not set the 'rhqctl install' command will prompt for a password and update rhq-server.properties with the encrypted value. Additionally, the rhq-encode-password.sh|bat machanism has been enhanced to allow the user to generate the value.
Add to Eclipse source dirs
Merge pull request #102 from rhq-project/bug/1124614
Add some logging that would have been helpful investigating bug 1117449.
1093265 Added some longer button disablement to avoid concurrent updates. If this "cheap" fix isn't sufficient we'd have to look at something server-side, and more substantial.
1126853 Alert does not trigger if defined with 'disable when fired' This was undetected fallout from the work done in BZ 1110434. Although, it's fallout that doesn't make a lot of sense. It's either a bug in HornetQ/Arjuna/EAP interaction Tx management, or we violated some very subtle J2EE/JTA rule. Basically this is what was happening: 1) alert condition consumer onMessage is invoked (with default CMT Tx semantics) 2) it invokes a series of nested SLSB calls with various Tx semantics, including REQUIRED, REQUIRES_NEW and NOT_SUPPORTED. 3) The NOT_SUPPORTED method hangs on method return, as such some downstream processing commits (due to REQUIRES_NEW semantics) but the upstream calls don't complete. So even though the alerting all worked, it never got to commit. 4) After 10 minutes the Tx reaper comes along and cancels the hanging Tx.
Some unsolicited slsb code cleanup - remove unnecessary/duplicate class level datasource annotations - use DatabaseTypeFactory.getDefaultDatabseType() where appropriate - add missing statement close in ResourceAvailabilityManagerBean - use util safeClose methods as appropriate
1127029 Agent null would like to connect to this server The issue here is that 'rhqctl install' does not make provisions for an existing agent on the machine. When installing an RHQ Server or Storage Node it is then expected that RHQ components be managed by the rhqctl facility. This is made possible when upgrading from pre-rhqctl versions by the 'rhqctl upgrade' --from-server-dir and --from-agent-dir options, which allow an upgrade to "pull in" the existing components on the machine. The missing use case is this one, when not upgrading but rather installing. So, this commit adds the --from-agent-dir option to 'rhqctl install'. Allowing a formerly installed RHQ Agent to be updated (as needed) and pulled under rhqctl, moving it to the expected location of sibling directory to the rhq-server installation directory (and not installing a new agent, which caused the reported issue) - Also, fix an issue in 'rhqctl upgrade --from-agent-dir' where the new agent was not actually moved to the proper sibling directory. I believe this affected RHQ 4.12 (and possibly JON 3.2)
1125439 Duplicate baselines metric entries Due to some git trouble this is something of a manually generated squash commit. The changes are somewhat two-fold. First, there are changes relevant to the initially reported symptom, which was the existence of duplicate baselines for a single schedule. The code looked like it was capable of generating a storing a duplicate, due to the use of Lists (not Sets) in the APIs, and also the lack of a unique index even though there is a 1:1 relationship between baseline and schedule. The first set of commits addressed these issues and also adding chunking to avoid large Txs and also oracle IN-clause limits. - Make the db index on baseline's scheduleId unique. There should only be one baseline for a schedule. This will prevent the problem in the BZ, possibly at the expense of failure when trying to store a duplicate, but that would perhaps help us pinpoint a problematic code-path. - Use Sets (or a Map) as opposed to Lists in several places in the local API. - Simplify and I think make more efficient the query for selecting schedules without a current baseline. Make it return distinct ids (this is a hedge, I don't think it would return duplicates, but this ensures that constraint). Replace a left join with a NOT EXISTS sub select. - Chunk the storage of baselines to prevent large Txs, don't pass entities across Tx boundary, fetch all Schedules in one query, and (maybe) simplify the entity manager interaction. - Simplify some of the TransactionAttribute decls - Mark MeasurementSchedule.baseline as an optional 1-1 relationship, just to make it explicit on the entity. - Fix some local SLSB jdoc
1061311 rhqctl contains user modifiable values that result in an unsupported rhqctl script Apply a missing fix to to rhqctl that was already in the .bat.
Merge pull request #65 from genman/BZ1032192
1070257 (JON3-36) Extend length of Details field of alert notifications One additional commit to the PR. Just use DatabaseTypeFactory.getDefaultDatabaseType() instead of figuring it out manually.
Fix db-upgrade.xml due to bad merge.
Fix test failure due to API change.
790101 - as5 plugin: warnings should not be logged for AS/EAP versions that do not require the corresponding jar I changed the offensive WARN-level message to DEBUG level. It's not really possible to distinguish between non-existent and non-readable, or to know which versions require which JAR. If there is a failure then we can turn on debug to see the message.
1075211 Cannot set custom value for Baseline - High property This really only is a problem when there is not yet a baseline. Which is rare and typically just between import and the next run of the DataCalcJob. It's not really easy to generate a manually set baseline from scratch, so I'm just taking the approach of better messaging and error handling: - Fix error handling such that the root cause of the issue is displayed when the save fails. - provide better error handling and provide more specific messaging - remove the confusing refresh icon (which was sort of acting like a save option. So, just hitting return is the way to save. - Hide the edit box when saving. - protect against GeneralUnhandledException when saving without setting a value.
The PR for BZ1032192 was created with intentional changes against 4.11 but was merged after the 4.12 release. Migrate the intential change decls to the newer version file.
1130085 rhq-server-env.sh.default is overwritten when first upgrade attempt fails Add FileReverters for the -env files. So, on cancel the unmodified version of the file should be restored.
rhqctl install was failing with issues like: "Could not complete storage cluster schema installation: Authentication error on host"
1133112 Inventory Merge is slow and consumes a lot of memory when a parent has many children In our continuing search for new planets, new civilizations, er, strike that, our need for better performance, this change ensures we don't pull child sets unnecessarily during inventory merge. This is very important in the given use case, but should benefit all inventory merge to some degree.
1035420 OOB content labels get cut off This portlet could use some more TLC, but at least now the metric name should appear in full. Added some better formatting to the list entries. Note that LinkItem.setClipValue(false) needed to be set explicitly despite being the documented default.
1006487 Manual autodiscovery is confusing Changed to "Run Autodiscovery" (cherry picked from commit eaf199722b103b98f9f04303364952d3c845d789)
1071282 disk size used by storage metric is invisible when no metric is collected 1071291 no-data-available metric values for storage node metrics
1131896 multi-click on New Dashboard button creates dashboards with the same title Prevent multi-click by disabling button until prior DB is created.
1136501 On Bundle Revert "Finish" Screen, Finish Icon Appears Not To Be Present Fixed Image reference.
Some I18N cleanup, every little bit helps reduce what translators have to deal with.
1136090 Resource selector may choose resources from other plugins than the selected one After discussing with Thomas (the BZ owner) we decided the best approach was to layer this fix on a new Criteria feature. This commit adds:
1127926 warning in rhq-storage-wrapper.log Fix the heap dump dir support for the storage service. This is a Windows only fix. Note that this fix only executes at storage install time or at resource config update. For existing windows storage nodes the resource config property for the heap dump dir must be updated to a new value. To maintain the existing directory, change it and then change it back.
1014669 RFE: Link to particular metric from Resource Metric graph portlet Added the resource name as a link in the Portlet window title, so it's now possible to link back. - also made analogous fix for group metric graph portlet - also fixed additional issue with graph disappearing on maximize/minimize
1009695 On agent shutdown an error is reported re: poller with PollerKey Don't try to unregister the poller shutdown if the threadpool is shutdown.
1026786 JBAS015960 warnings during JON start up - invalid classpath entries in deployment Add logger subsystem filtering to omit the error codes we don't want to see. Filtering out the "invalid class-path" as well as a few other annoying warnings. - added installer support to set the filter in the standalone-full.xml.
768342 Incorrect work of Resource Group Metric Graph portlet The datasouce backing this select item had issues. Fixed that. Also, fix a tangential issue in the MeasurementScheduleCriteria resource type filter.
1030089 Horrible error messages - no host identification Add ancestry info to each failed/canceled resource. Also, indicate that the full details are available via the group op history and the individual res op histories (via the GUI, or programmatically).
1001383 getResourceConfiguration does not return the current resource configuration Improve some ConfigurationManagerRemote javadoc, making it more clear that getLatestResourceConfigurationUpdate() satisifies the API request in the BZ (I think).
1001383 getResourceConfiguration does not return the current resource configuration Further improve the confusing/incomplete javadoc surrounding the get/find configuration remote API methods.
1136488 (domain mode) application version is 'none' for domain deployments Add versioned-deployment logig to domain deployments. This includes resource upgrade for existing resources. Also, tweak the operations to use the correct path value as opposed to the version-stripped resource key.
1140806 Starting agent with disabled plugin types in inventory causes 'Could not load inventory from data file' error Change removeIgnoredResourcesFromChildren() to avoid using Iterator.remove because it is not supported in our underlying CopyOnArraySet impl type. – also, don't recurse on ignored children, that branch is already chopped off at the head.
1132952 Process and some other platform services are not listed under group creation dialog search filter complement previous work adding sorting of the type names.
1131494 CLI command to remove storage node gives transaction error Needed to establish a new transactional context.
1138328 globally uncaught exception on storage metrics admin page Although I was still unable to reproduce this bug I did find a couple of places where we needed to shore things up, that perhaps contributed. - fix getResourceIdFromStorageNode utility to throw the correct exceptions, this solves issues where caller catch definitions were not catching. - when uninventorying a Storage Node Resource we did not pro-actively unlink it from the StorageNode entity. We did the unlink in the async work but that that left the bad resource linked until async job ran or until it was re-linked to a newly imported SN resource. Now unlinked up front (which is unfortunate as it adds another db query per batch).
1128151 Error while upgrading from JON 3.1.2 to 3.3: rhq.autoinstall.server.admin.password must exist and be set to a valid string value Ensure that the property gets a string value assigned during upgrade so that the properties file passes validation. The dummy value is "ignored-on-upgrade", the rhqadmin user will already exist in an upgraded server's DB.
1078500 SEVERE error in Server.log file: JSF1051 This is generated due to, I think, EAP Bug 1141373. The error does not seem to negatively affect rhq/jon, so at this point I'm just filtering out the message from the server log.
1035420 OOB content labels get cut off Analogous fixes for the measurement portlets
Related to work for 1138328. Wrap the new non-async uninv work for storage node unlinking in a new Tx, like the other work done in that method. This may prevent an Oracle locking issue seen in test code cleanup where we call both the sync and async uninventory in quick succession, under potentially the same umbrella Tx.
1071379 CTRL+C doesn't shutdown server when running in console mode on Windows Rhqctl was actually the program running in the foreground when the 'rhqctl console --server' command was issued. The JSW and Server processes were also running, but in the background. When issuing a CTRL-C it was actually rhqctl that was getting interrupted and killed. The CTRL-C was not reaching the wrapper, or the server. This got a little infuriating because even if you manually killed the Server, the wrapper would detect the "crasg" and then spin up a new server process
So, to recover you needed to manually kill the wrapper.exe process, and then manually kill the RHQ Server process.
1064332 Horizontal size of the dashboard's left panel gets stuck after changing verticle panel size When we removed the borders from the dash columns it made it very difficult to grab anything for horizontal (i.e. width) resize. There was only a small, invisible area at the '+' shaped intersections of portlets.
1043099 Add new autogroup chart to dashboard shows empty chart in dashboard Disable the ability to add Autogroup or Autocluster metric graphs to the dashboard. It doesn't work because the portlets don't support them, and these types of implicit groups should not be referenced outside of their Tree navigation context. Despite being persisted they are maintained only at click-time.
1073691 Table deadlock issue when processing content report due to missing index and very large transactions in ContentServerServiceImpl.mergeDiscoveredPackages This is yet another legacy code spot subject to scalability and locking issues. I've made a pass at making it more scalable and less likely to lock: - No longer process an entire report under an umbrella Tx. Break up the work into more, smaller, Txs - Reduce # of DB round trips - Remove several calls to unindexed queries - Note, no new indexes have been added at this point. We are still likely doing one full-table scan of rhq_installed_package when getting the InstalledPackages for a Resource. We may want to add an index on that FK. - Altered queries to use indexes - Removed unused queries from InstalledPackage and PackageVersion - Added some inline doco to help future genrations - Removed duplicated remote method decls from ContentManagerLocal - Fixed an issue in ContentManagerBeanTest and re-enabled a bunch of tests
1073691 Table deadlock issue when processing content report... add a perf-oriented unit test
1143918 Addition of new Log Event Source using JBoss ON CLI will break the UI if all properties (even unset ones) are not added Add support for the missing properties in this use case.
Prevent ConcurrentModificationExceptions that have been showing up in the Jenkins test runs of this class.
An attempt to fix the intermittent failures for AvailabilityProxyConcurrencyTest.testConcurrentAvailChecks(). I believe the issue is that depending on random ordering, we could exceed our set timeout for the synchronous avail check, which we don't want to do in this test. I added a bit more console output to help diagnose a failure in the future.
1108168 storage node name in cluster alerts is null Ensure async initialization complete before rendering
Work related to test failure in AvailabilityProxyConcurrencyTest - Two changes to AvailabilityProxy itself - make AvailabilityProxy.getAvailability() a synchronized method. We don't want two threads calling this concurrently. This is not too likely in production, given intervals between checks, but may have been possible when performing a live check. The test code on the other hand was sometimes failing due to parallel execution of the call. - stop AvailabilityProxy.getAvailability() from converting UNKNOWN to DOWN when the avail check is asynchronously in progress. This breaks the contract as stated in the javadoc and could lead to false DOWN reporting. (although, conversely, now fixed it could take longer for valid DOWN to be reported, as a check may need to timeout). - unrelated but update AvailabilityFacet javadoc to add in valid MISSING state om> - work on the test code. replace the concurrent thread approach with the more realistic serialized calls and change timing around to more predictably mix some calls that complete synchronously and some that complete asynchronously.
1144459 eap6 Warnings in agent.log - Required property 'manage' and 'delete-durable-queue' have a null value An issue in the plugin descriptor resulted in an ill-defined configuration definition for the 'Role' "list of maps". Fixing the descriptor should resolve the issue when resource config is rediscovered for an existing resource. New resources should be fine from the start.
1144998 List of errors and warnings in server.log after upgrade to 3.3.0.ER03 Add EAP-level log filters for messages we can't avoid and don't want to see.
1033404 Updating Blocking Bounded Queue and Bounded Queue Thread Pools fails without core-threads value This is a partial fix for the reported issue, and contains two associated fixes for issues hit while working the issue. - First, The plugin descriptor needs to specify required="false" for the optional simples in a map of simples, otherwise they will be set to required="true" by default (I don't know if this is true for all props, it may be, but it was definitely true for the keepalive-time map-of-simples for AS7 ThreadPools). Otherwise values will be expected. Fix this because this prevents the create child from working unless you sepcify keepalive-time. - Second, a map-of-Simples in a resource configuration always generates a Map in the Configuration, even if the Map is "empty" because the Simples are all "unset" (set to null values). This was not being handled well in the create resource code, where an unset map should be ignored as if the entire PropertyMap is "unset". Note that an empty MapProperty in a configuration update should be processed, because we may be trying to unset one or more of Simples that currently have a value. - Third, to work around the fact that AS can't currently handle an undefine (i.e update to null) of core-threads (and possibly other attributes), add an optimization such that we don't try to update undefined (null) attributes to be undefined, since they are undefined already. - There was another issue in that the plugin code was actually modifying the ConfigurationDefinition held in the ResourceContext (which is a weakness in our design that we even let that happen). Changed to use a copy of the ConfigurationDefinition (and added a copy() method in the Entity, migrating it from plugin code where it was previously defined).
eclipse classpath updates
822173, 1146846 Broken layout on JBossAS7 resource configuration page Work done for Bug 1144459 was unknowingly trying to fix the problem reported in Bug 822173. It succeeded in fixing the column header issue but caused the regression reported in Bug 1146846. This (finally) seems to have fixed the problems for all three BZs, working around the Smartgwt bug at the root of all of the problems.
1139735 HA upgrade issues with storage cluster schema change First check-in for the necessary revisions. What makes a storage cluster schema change difficult is that it requires the entire storage cluster to be upgraded to the new bits, and to be running, in order to apply the changes. This runs contrary to our typical upgrade approach which is to shut everything down and upgrade one install at a time (an install being a server and/or storage node). The basic approach is to now track the install version for each installed component, and only when evrything has been upgraded, then do we allow the storage cluster start and then perform the schema update as a separate upgrade step. - Add version stamp on rhq_server and rhq_storage_node - Add db upgrade logic to add fields and init them to the current version - Add Support to stamp the version on install and upgrades - includes updates to jboss modules, rhqctl and installers - includes ability to contact RDB from storage installer - Add --storage-schema and --list-versions coptions to rhqctl upgrade - Stop server startup unless topology is set to homogenous version, to prevent running an environment that is not completely upgraded.
1149684 Repair only runs on one storage node Fix regression resulting from work for Bug 1111064. What were formerly attached entities were now detached, so inline updates had no effect.
1139735 HA upgrade issues with storage cluster schema change Commit #2: Remove the server-startup requirement for performing upgrade --storage-schema. This was bad as the server is already installed/upgraded at this point. Also, this reduces complexity, improving chances of success.
1149886 can't start storage node if java installed under somewhere with dir name of bin/java Fix mazz's goofy use case
1139735 HA upgrade issues with storage cluster schema change Revert the flawed db-upgrade logic. We can't update all existing rows in the server and storage_node tables, only the one being upgraded can be set to the current version. But this is unknown to the upgrade logic. Instead create the new column on the fly during the first upgrade that wants to set it. Set all rows to an "old" version, and then update only the one row that reflects the upgrade in progress. This also has the benefit of restriction on upgrade ordering.
1139735 HA upgrade issues with storage cluster schema change - Fix using the wrong value for storage node address in the version update - Update logic to complete DDL changes prior to the version stamp, in case of failure the DDL changes will still be complete. - Change version stamp to fail more significantly since it really does mess up the install/upgrade, now throws exception as opposed to just returning a boolean success flag. - add some more in-line doco and improve list-versions output
Merge remote-tracking branch 'origin/master' into jshaughn/1139735
Merge branch 'jshaughn/1139735'
1139735 Add undo of the storage node version stamping in case of an upgrade failure invoking undo logic. The current thinking is that this is not necessary for the server stamp since it happens at the end of server upgrade.
1146096 Alert definition/notifications show with unknown configuration - Don't let a bad notification summary break display of the list of summaries, instead show an error describing the problem (like File Not Found). Note that this message comes from the server and therefore can not be localized. - provide better Message Center error when going into the detail dialog (presumably to change to a valid resource) - Fix a broken icon issue when viewing successful operation notifications and their "Deferred" status.
1151441 - JON server was unexpectedly stopped after ~ 1 day Improve log message relevant to the reported failure. I think this issue is due to a change of IP, or some other change to the result of InetAddress.getLocalHost().getCanonicalHostName(), which is the default value for the server if it is not explicitly set in rhq.server.high-availability.name.
1151441 JON server was unexpectedly stopped Only resolve the identity of the running server (i.e. the SERVER_NAME) one time and cache it as a static for ServerManagerBean. This is more efficient as the server name can not change at runtime, and actually should not change for a defined server, ever, in general. Moreover, for server where rhq.server.high-availability.name is not set, it prevents repeated calls to InetAddress.getLocalhost(), which can fail if there is a temporary DNS issue, and the localhost can not be resolved.
1139735 fix test failures Now that the storage installer needs to contact the DB to version-stamp the rhq_storage_node table, the cassandra installer upgrade tests failed, because they support no DB infrastructure. To get around this added an installer option to ignore the version stamping. These options are not user-visible, and who knows, maybe someday support will have a reason to use it.
1151441 fix i-test failures We can't cache the server name in the static block because i-tests don't set rhq.server.high-availbility.name that early in the setup. It was fine for production. So, now lazily cache the server name at the time of the first request for server name.
1151441 fix i-test failures (2) The i-tests actually set/restore rhq.server.high-availability.name sysprop in the before/after methods. This allows testng to jump around and execute tests in different classes, in different orders, while the server name remains correct for each test. Update the server name caching mechanism to reset the cache when sysprop changes are detected. I don't think this has any production use case, but it's required for testing, doesn't cost much, and still keeps the original fix for this BZ intact.
1139735 More i-test fallout, oracle only Unlike Postgres, where DDL changes can be transactional, Oracle executes DDL (like adding a column) like autocommit=true. As such, it can't happen within an existing Tx, which is what we have by default in out itest setup beans (@PostConstruct). Change things to execute the DDL outside of an existing Tx.
1149265 Main menu bar appears on top of Favorites menu in IE This commit in effect reverts the CSS changes but keeps the fixes to I18N and the user menu href. Additionally: - Remove FavoritesButton as that button was no longer used, and replace with FavoritesMenu. - Remove some explicit zIndex settings and defer to the css defs in play due to the recent work for BZ 1144052. Keep explicit zIndex for the MessageBar to ensure it gets precedence. - Simplify menu bar interactions by clearing the message bar if the favs or user dropdowns are clicked on.
1092707 If re-install is attempted using a different storage node host name, install fails Allow a re-install/re-upgrade to replaceme existing storage node definitions as long as the storage nodes have not actually been used. Basically, if none of the storage nodes are yet linked to a resource, they are eligible for replacement.
1155612 upgrade from jon 3.1.2 to jon 3.3.0 er05 does not work Fix an install issue when upgrading from a BSN (before storage nodes) version. Go back to the legacy db-upgrade step that adds the entire rhq_storage_node table and make it match the same table definition you'd get from a new db. Because no SNs existed at upgrade-time the version column updater never gets a chance to execute. And therefore the insertion of the initial SN fails.
1155991 EAP5 Unable to create datasource/Queue/Topic via JON We only want to trim the managedProperties when updating ResConfig, not when creating a resource. In that case all props need to be set appropriately.
1139735, 1157480 More upgrade use cases that didn't work. 1139735 An upgrade with a number of storage nodes > than our replication factor (>= 4) could fail because our check for the storage cluster version can fail if the auth info or version info are not replicated to the currently running SNs. To avoid this, for ugrades we now push all storage cluster interaction to the post-upgrade step (i.e. rhqctl --storage-schema). This includes the schema creation for a new, remote storage cluster.
1157480 resolve a test issue by better supporting a missing rhq-server.properties file if the --no-version-stamp option is specified.
1159003 Alert notification sending fails due to database deadlock error Remove the umbrella Tx surrounding sending of alert notifications. It used to be that all notifications would be sent in one REQUIRES_NEW SLSB call. It was necessary to do this because the notifications were themselves sent within a larger, very heavy, umbrella Tx that involved the alert generation itself (among other things). Prior work restructured that logic and moved notification sending to a more logical place, executing after alert generation, cache update and recovery logic handling. But the prior work left the notification sending under a single transaction. This isn't really necessary or desirable. Each notification should be processed individually, not holding any resources past its execution, and persisting each notification log in its own Tx. Although not proven, the deadlock situation was likely caused when an alert definition defined multiple notifications, and one held resources required by another.
I18N work - backport near-complete German l10n - backport near-complete Japanese l10n - remove the far from complete Russian l10n - remove a couple of redundancies - comment out some untranslated properties (as per convention)
1160682 Upgrade from JON3.1.2 to JON 3.3 CR01 with run-data-migrator option shows AuthenticationExceptio This happened because the storage cluster schema is not yet created. It won't exist until 'rhqctl upgrade --storage-schema' is executed, after all RHQ Servers have been upgraded and standalone SNs have been installed.
1160669 Failed upgrade of standalone storage node is not correctly rolled back This was true of any storage node upgrade failure, not just the new db properties issue reported. But the new properties is the most likely new reason for a failure. Changes to fail the overall upgrade on any non-OK status returned from the storage upgrade. This shouldbe safer, and prevents the server from trying to upgrade if the storage upgrade has an issue.
1092707 If re-install is attempted using a different storage node host name, install fails During install, contact the storage cluster using the DB defined storage nodes if they are already managed (at least one is linked to a resource), otherwise defer to the rhq.storage.nodes property value and redefine the persisted storage nodes with the potentially updated addresses.
Jean-Frederic Clere <jclere@redhat.com> (6):
BZ 1119652 ] Webappp configuration - Config File field is mandatory.
BZ 1120696 ] EWS RPM installed Tomcat version is not discovered.
Add BMX support.
Finish fixing mod_bmx support.
Allow multiple httpd per agent when using mod_bmx.
Detect the mod_bmx configuration and make snmp one not mandadory.
Jirka Kremser <jkremser@redhat.com> (76):
Increasing the height of LDAP registration form (not to show the scrollbar).
Making the Import button blue as it is a primary action in discovery q.
Merge pull request #87 from alns/BZ1118926-MissingIcons
Merge pull request #82 from alns/checkBoxes
Merge branch 'patternflyTable' of https://github.com/alns/rhq into alns-patternflyTable
Merge branch 'alns-patternflyTable' (pull request #83) There was a conflict, therefore merging it manually.
Merge pull request #85 from alns/BZ1119372-ButtonTextColor
Changing light-yellow for light-blue. It was used on the date picker and the EnhancedSearchBar component (the color for hover effect)
Calling Pace.restart() instead of Pace.start() because it was not working if two calls of Pace.start() happened after each other. restart() is a suggested way of calling the progressbar manually.
Gray background for each EvenRow even if it is currently disabled.
BZ 1058318 ] - Unable to create 2 alert defs in a row - gwt serialization error - Simplifying the objects that are sent over the wire not to cause troubles with the GWT2.5.0 serialization bug.
BZ 1116784 ] - Patternfly theme: upload button needs to be pressed twice - making the upload button enabled by default and removing the change handler that was causing the problems, also fixing the height of the button in FF
Merge pull request #91 from alns/BZ1120816-ResourceBadgeAlwaysUP
patterfly: fixing typo in image name (_over -> _Over); increasing the size of icons for availability; decreasing the size of icons for event severities; removing unused images
pf: simple bash script for lightening all the black icons
pf: lightening all the black icons
pf: better icons for storage node, plugin and refresh
BZ 1122549 ] - LDAP user registration screen does not appear when 'Enable Login Without Roles' has value 'No' - SubjectManagerBean.processSubjectForLdap() was calling the SubjectManagerBean.login() where the exception was thrown, but the roles get assigned after this step. Now the login method is called with additional parameter that says 'don't do the role checking'. There was also a logical error that actually caused that no RHQ roles (based on LDAP group) were assigned at all (it was done correctly only when the log level was set to DEBUG)
pf: invisible scrollbars are not invisible anymore, font color
pf: improving scrollbars, calendar popup widget now uses same colors as the rest of the ui, adding shadows to popup dialogs, removing unused css link reference from login page, listgrid on users view now has 1 column that takes the rest of the screen's width, etc.
Making the new mashup portlet's scrollbars look relativelly same as the rest of the UI (using the jscrollpane JQuery lib, because there is currently no way to change native scrollbars in FF so we need to use fake ones)
Increasing the height of the scrollpane for the mashup portlet, because I forgot to do that in my previous commit e60acc22d
BZ 1125972 ] - JON 3.3 Administration/Affinity Groups page is incorrect. Button is missing to create new affinity group - This issue was caused by spaces in id (BaseWidget.setID())
pf: fixing the relative paths to the images from patternfly-custom.css
BZ 959455 ] - Confusing number of total rows in Administration->Agents page - calling setPagingInfo(response, result); solves the issue. I fixed that also for StorageNodeDatasource, AffinityGroupWithCountsDatasource, FailoverListItemDatasource, PartitionEventDatasource, ServerDatasource and ServerWithAgentCountDatasource
BZ 1122512 ] - Missing remove_Disabled.png icon - adding the icon
BZ 122500 ] - Ok and Cancel buttons are scrolled out from visible area of modal dialog - increasing the size of popup to make the buttons visible; also improving the select items.
BZ 1083479 ] - Second invocation of about dialog fails - creating the dialog from scratch (instead of using the cached instance that was causing the issue). Also adding a link to GitHub commit corresponding to the build number (only for RHQ).
BZ 1127654 ] - Patternfly theme: various minor UI issues - window header icons, better icon for pencil (edit), fixing mouse cursor for header icons
removing the unused '/rhq' directory that came up from Alan's commit eeaad79aca7f7dc07b96993e9ed2362d26fdd8c0
Removing the dotted outline from the content of mashup portlet.
BZ 1125972 ] - JON 3.3 Administration/Affinity Groups page is incorrect. Button is missing to create new affinity group - Using utility method for replacing spaces and other forbidden characters in smart gwt id field for UI components.
BZ 1128276 ] - Custom time range, if set with invalid wrong range, cannot set back - Adding a client side validation in web UI
BZ 1129051 ] - Long alert definition templates list is displayed partially - calling setPagingInfo(response, result); solves the issue. I've fixed that for various data sources.
BZ 1126923 ] - upload bundle recipe button does not work for first time - doing the same changes as introduced in commit 132e2f1f0fa5d31 for component TextFileRetrieverForm.
BZ 1031980 ] - typo in server settings "GUI Session Timeout" description - typo fixed
BZ 1070257 + BZ 911432] - Increasing the size of db column RHQ_ALERT_CONDITION_LOG and adding an explicit way to match alert condition on event source
BZ 1070257 + BZ 911432] - ensuring the value passed to AlertConditionLog.setValue satisfies the db constraint (for Postgres it is AlertConditionLog.MAX_LOG_LENGTH chars and for Oracle AlertConditionLog.MAX_LOG_LENGTH bytes).
BZ 1132399 ] - Plugin config for group has the save button on the top - placing both buttons on the bottom of the page and making them blue
BZ 1031730 ] - Dashboard graph group does not retain group configuration - SingleResourceGroupSelector component now pre-selects the group stored in user prefs
BZ 1127654 ] - Patternfly theme: various minor UI issues - The height of popups for assigning a server or agent into affinity group was enormous.
BZ 1132400 ] - metrics load icon visible forever for storage nodes auto-group - processResponse() even if there are no metrics to remove the spinner icon
BZ 1031730 ] - Dashboard graph group does not retain group configuration - removing one unnecessary call of doPostPopulateAvailableGrid(), adding i18n for a message from AbstractSelector, reducing visibility from public to protected
BZ 1028329 ] - Refresh button does not refresh metric data on autogroup - The refresh button for GroupMembersHealthView will invoke the refresh also on the GroupMeasurementTableView component.
BZ 1000173 ] - Missing Disabled icons (404 not found) - when resizing the portlet, SmartGWT change the icon to the '_Disabled' form, but the icon was missing for 'Package_16.png'. I've added all kinds of portlets and it was the only one missing.
BZ 1020874 ] - Add subscriptions button on platform->Content->Subscriptions tab displays HTTP Status 404 in UI - adding the form action JS hack
BZ 1133590, BZ 1133909 - Upgrading the version of Red Hat Access angular app, where the issues are already fixed.
BZ 1029389 ] - "Administration->Servers" action buttons disabled when I click "Remove Selected" confirmation as "No" - calling refreshTableInfo() for all ways to close the confirmation window
BZ 1139267 ] - Undeploy Selected button on Storage Nodes page is disabled so it's not possible to remove second storage node - there was an error when checking if the storage node is available
Changing the descritption for a system setting from value 'If not enabled, the coregui will block users that are not assigned to any role. This applies for both LDAP and normal users.' to 'If enabled, logins are allowed for users not assigned to any role. This applies for both LDAP and normal users.'
Merge pull request #119 from ppalaga/RHQ-build-from-anywhere
BZ 1070277 ] - (JON3-39) JON should (be able to) block login to a user without roles - Changing the default of the property to true, i.e. enabling the login for user without roles by default.
BZ 1145101 ] - Email alert notification field 'Condition' contains characters which are not part of defined condition - Changing AlertManagerBean.prettyPrintAlertCondition() method to incorporate the changes in alert condition instance for events (the option field is used to carry two regular expression; one for the event details and one for the event source path).
BZ 1083894 ] - Storage node's cluster status "NORMAL" written in RED cannot be changed - Adding a way to our UI to explicitly reset error message and last failed operation on the rhq_storage_node table.
BZ 1070277 ] - (JON3-39) JON should (be able to) block login to a user without roles - adding it to the db-upgrade.xml also using lower case in sysconfig-data.xml
BZ 1133947 ] - Unregistered LDAP user without role can login to CLI - introducing loginLocal() method to be able to find out that user is comming from CLI (the case when SubjectManagerRemote.login() is called) and let him fail if it is LDAP user and is not registered in the system. This is now consistent with the REST endpoint, where we assume the registered LDAP user as well.
BZ 1144052 ] - On group creation error, info messages are under fadeout window - the z-index css attribute was ignored, because there were two different so called stacking contexts. By setting the z-index to the default value (which is auto) to all related parent elements we prevent creating new stacking contexts. In other words z-index works correctly only for leave elements in the DOM tree, but if we combine different z-indices in one sub-tree it causes strange behavior.
BZ 1146228 ] - Metric detail hover is missing from graphs - this was caused by "! important" in style definition in patternfly.css because it overrided the elements style attribute (where we programatically set if the hover is shown of hidden). I've created a new css style called rhqHidden where the "! important" is not used.
BZ 1144052 ] - Setting z-index to auto to all parents of the logout dropdown menu to join its DOM subtree to the global stacking context and make the z-index working again for it. Result is that it will be on the top even if there is a notification. Also hiding the ajax loader gif icon, because it is not needed anymore.
BZ 994267 ] - LDAP login causes Invalid path was requested error to appear in server log - Ignoring 2 particular the log messages coming from the JSF layer.
BZ 1146266 ] - Metric graph is empty if high, low, and avg values are all the same for every time bucket within the selected time range - d3.scale.linear().domain() funcion excepts an array with >2 distinct elements. The global min and max were used here, but if all the values were the same it didn't work so I've changed it to 0.9 * min, 1.1 * max if min == max.
BZ 1149687 ] - Storage Node's cluster status is DOWN when cluster maintenance is scheduled - considering the MAINTENANCE operation mode as NORMAL cluster status.
BZ 1114600 ] - Cannot load Metric red error when client time is different from server - trying to resolve the time into # of milliseconds on the server side where the referential time zone is used. Introducing a new class called Moment for storing 5 integers: year, month, day, hours, minutes.
BZ 1114600 ] - Cannot load Metric red error when client time is different from server - Moving Moment.java to core/domain module. There was CNF exception during the install, but also CLI can benefit from this timezone independent class as well. (because depending on number millis from 1970 is confusing - it may return different number on different timezones)
BZ 1114600 ] - Cannot load Metric red error when client time is different from server - Renaming Moment.java -> Instant.java to be 'language compliant' with Joda time and Java 8 time API.
BZ 1114600 ] - Bulk revert of 3448429138161, cb5078b367f9e and 546cf53e3c588 - I reproduced the issue by changing the time on a client (browser) machine. But we don't support such a behavior. When changing only the timezone, I didn't reproduce the exception.
BZ 1149265 ] - Main menu bar appears on top of Favorites menu in IE - bringing favorites menu into foreground (by resetting the z-index to all it's parrents and setting it's z-index to a high value, all in CSS)
BZ 1149265 ] - Main menu bar appears on top of Favorites menu in IE - Incorporating the changes from Jay's pr #137. I.e. I18n, Remove the '#' href from the current user dropdown
BZ 1149265 ] - Main menu bar appears on top of Favorites menu in IE - z-index++
BZ 1138688 ] - windows unable to log in to JON from FF - adding some magic to make the logging in working on newer browsers. Basically, some waiting (20ms) needed to be added before the redirect. Because of the fact that /login and /Coregui.html both uses the same gwt module some logic was added to distinguish between them and prevent the UI from rendering when user is still on the /login page.
BZ 1150586 ] - On first login attempt, LDAP user remains on login screen without any message when - Enable Login Without Roles=No and there is no mapping between JON roles and LDAP groups. - Displaying the generic error message for the first attemnt as well. Also disabling the login button, during the login procedure, because login using LDAP takes some time and we don't want users to click on the button invoking another checks.
Adding stellar.yaml (config for database snapshot tool) to the .gitignore
BZ 1160265 ] - Cannot select/unselect permissions while creating roles on Firefox 29
BZ 1160775 ] - RFE Adding a way to show/hide RHQ subsystems in UI
Merge pull request #145 from rhq-project/ui-subsystems-customization
irc bot: adding new irc server address determining if the bot is running inside Red Hat network or not
John Mazzitelli <mazz@redhat.com> (25):
BZ 1118906 - support upgrading the agent via rhqctl when the install location is being referenced by a symlink
BZ 1107338 - show all bundle files in the list
BZ 1124614 - if an agent's auto-update is enabled, then always update itself if its version is not the same as the latest agent version of the agent distro in the server
trivial fix to source path for eclipse
BZ 1133061 have installer apply workaround so agent can send large messages to server over secure https connector
BZ 1096923 - revert the standalone-full.xml if any errors occur during install so a re-install attempt will work
Merge pull request #114 from burmanm/remote_agent
BZ 1134486 - bundle deploy wizard group selection drop down is getting some odd events with a null value. don't know why its happening, but this fix codes around spurious events with new values being null
BZ 1138805 - NPE check
BZ 1124619 - provide more responsiveness when you want to ask an agent to update itself from the GUI. There is now a "update agent" operation, rather than requiring the user to use "update --update".
BZ 1088032 - show a warning message if readlink doesn't exist.
BZ 1088032 - use "command" not "type" since "command" is POSIX compliant and is available on Solaris as well as other UNIX flavors. Don't use readlink unless we know it is available, to avoid spitting out those error messages. Tested on Solaris 10 ("uname -sr" returns "SunOS 5.10") and readlink does not exist, but "command -v" works so this fix should work on Solaris 10.
BZ 1141175 - make sure installer works even if the management bind address is set to 0.0.0.0
BZ 1142108 - fix NPE - in case someone deleted jboss.bind.address.management from rhq-server.properties
BZ 1141181 1129413 - don't echo passwords to the console. ask to confirm passwords
BZ 1129729 - catch any exceptions if a plugin failed to be processed during detection - this should allow the rest of the plugins to continue to be processed.
BZ 1145683 - change if-stmt so it can work on solaris 10 - semantics slightly change, but since we don't support JVMs lower than 1.6 that means that effectively this doesn't change functionality
BZ 1145338 - to support NAT environments, allow server to be configured with a public port/secureport when it is installed
BZ 1150064 - print message telling user the password did not confirm
BZ 1152154 - wait a few times during startup to ensure the agent has been given a fair chance to register before aborting
Merge pull request #144 from rhq-project/bz1095508
BZ 1158228 - to support install on Windows, allow for agent to be told to reload its agent config xml via marker file
BZ 1158948 - make sure agent can start/stop via rhqctl on solaris 10
BZ 1160851 - add the ability to wait for N seconds while testing for the server to come up. Default is 60s, but there is now a backdoor sysprop you can set if you want it to be longer or shorter.
BZ 1166383 - ensure a transport param is added to the remoting locator URL
John Sanda <jsanda@redhat.com> (44):
upgrade to Cassandra 1.2.18
fix test that started failing after C* upgrade
Merge pull request #95 from lzoubek/bugs/1074632
BZ 1126500 ] handle aggregate metrics with NaN as a value
BZ 1049054 ] add aggregate_metrics table
BZ 1049054 ] remove legacy constructors from AggregateNumericMetric
BZ 1049054 ] add automated test for aggregate metrics migration
BZ 1049054 ] log schedule ids for successfully migrated data
BZ 1049054 ] removing dbutils dependency since it created a circular dependency
BZ 1049054 ] set write rate limit based on number nodes and server property
BZ 1049054 ] temporarily comment out references to new table
BZ 1049054 ] set column timestamp in order to preserve original TTL
BZ 1049054 ] fix failing tests
BZ 1049054 ] refactor metrics migration test
BZ 1049054 ] fix baseline tests and clean up baseline calculation code
BZ 1049054 ] clean up/remove commented out, obsolete code
BZ 1135629,1135603 add metrics_idx table and remove cache tables
BZ 1135629,1135603 remove CacheAggregator and more clean up
BZ 1135629 ] add paging for index queries
BZ 1135629 ] first step in using a configurable number of index partitions
BZ 1135629 ] fix merege conflicts after rebase
BZ 1135629 ] add support for upgrading from RHQ 4.11 index
BZ 1135629 ] and test for replace index in RHQ 4.12
BZ 1135629 ] do not load the full index into memory during data aggregation
BZ 1114202 ] handle failures in aggregating 1 hr and 6 hr data
BZ 1114202 ] use separate thread pools, more clean up
BZ 1114202 ] fix some logging
BZ 1114202 ] fix compilatio error
BZ 1114202 ] check for empty list when computing metrics and clean up type params
BZ 1135629 ] make number of partitions hard coded for now
fix test that fails on jenkins upgrade jobs
Merge pull request #127 from genman/BZ1144238
BZ 1144238 ] fix compiler error and update dependencies
BZ 1114199 ] Make sure data expiration is consistent for late data
BZ 1114199 ] do not update insert statement caches more than once in a day
Revert "BZ 1114199 do not update insert statement caches more than once in a day"
Revert "BZ 1114199 Make sure data expiration is consistent for late data"
BZ 1114199 ] fix handling of late data
Merge pull request #130 from burmanm/BZ1146138
Merge pull request #131 from burmanm/storage_limit
fix upgrade test failures
BZ 1108095 ] fix compiler errors
attempting to fix upgrade test failure
BZ 1152807 ] changing aggregation settings should not require server server restart
Jérémie Lagarde <jer@printstacktrace.org> (6):
BZ 1100998 : Discover the <Directory> directive without using Augeas
BZ 1100998 : Applying Lukas's comments (removing augeas and using runtime config)
BZ 1100998 : Discover the <Directory> directive without using Augeas in IfModule directive
BZ 1100998 : Find directory recursively in ifmodules
BZ 1100998 : Discover the <Directory> apache directive recusively on vhost
BZ 1100998 : Discover the <Directory> apache directive recusively on vhost and ifmodule
Larry O'Leary <loleary@redhat.com> (1):
BZ-1124767: Setting appropriate defaults for new properties trustStrategy and hostnameVerification introduced in BZ-1062552.
Libor Zoubek <lzoubek@redhat.com> (85):
as7 properly detect when we fail to read attribute, but still are connected and authenticated
BZ 1093374 - JON plugin for AS 7 cannot create an admin user in a moved configuration directory
also return correct path based on domain path-names
BZ 1118279 - Disable password auto-complete all over UI except login page
BZ 1053483 - RHQ Admin UI references 'Cassandra' rather than storage node
Merge pull request #84 from lzoubek/bugs/1053483
BZ 1074632 - RFE: Manage storage node snapshots
BZ 1122047 - If 'Accept' header field is not explicitly specified, server responds with empty body upon REST query metric/data/{scheduleId}/raw
StorageNodeComponentItest - output more details when assertion fails
next attempt to fix storageNode takeSnapshots itests
mashup portlet now shows static page instead of IFRAMEd RHQ documentation
BZ 1125173 - Upgrade RHA angular UI to tag 0.9.0
BZ 1069662 - (JON3-16) Adapt JON UI title bar to common Red Hat L&F
BZ 1074632 - RFE: Manage storage node snapshots
BZ 1041393 - alert notification of type Resource operations is not correctly rendered by API
BZ 1127264 - Creating alert notification of type Resource Operations ignores extraConfig field
BZ 1070323 - (JON3-41) JBoss ON must support JBoss Diagnostic Reporter (JDR)
BZ 1119240 - Adding http-interface in the host controller's host-slave.xml is not recognised by JBoss ON Agent causing Host Controller's availability to stay DOWN
Merge pull request #97 from lzoubek/bugs/1074632
BZ 1128141 - HostController gets DOWN when name attribute in host.xml is empty
Fix output when updating storage schema
bump schema version
BZ 1074633 - RFE: Manage storage node snapshots
BZ 1129304 - Newly imported resources are not included in dynagroups which use resourceConfiguration in expression for several hours
BZ 1113593 - Blank space around value of rhq.server.email.smtp-host property in rhq-server.properties is not removed and causes java.net.UnknownHostException when starting RHQ server
Set top margin to rha content
BZ 1131341 - Hard to select RH Access -> Search menu item since notification has been shown
BZ 1132167 - Tag menu item is visble in JON
BZ 1134367 - 'Red Hat Access' open new case with jdr report throws exception if JON is under proxy
BZ 1049054 ] correctly obtain jboss server data dir
BZ 1127818 - Configuration of EAP 6 datasource resource is invalid when a system property is used in configuration for pool sizes
BZ 1049054 ] fixed typo
BZ 1128141 - HostController gets DOWN when name attribute in host.xml is empty
BZ 1134829 - Listing two times each case details under 'Red Hat Access->Support->My Cases'
BZ 1142356 - take snapshot failure exception for down storage
BZ 1128141 - HostController gets DOWN when name attribute in host.xml is empty
BZ 1138784 - eap6 NPE when loading configuration for datasources subsystem of managed server
BZ 1144046 - Uncaught exception when selecting Administration -> Security menu item
BZ 1140637 - JBoss layered product (JBoss Fuse) does not have direct option to open new support case
BZ 1144452 - "Open Support Case" must support all layered products
BZ 1084586 - Horizontal scrollbars are missing from Dashboard
BZ 1144046 - Uncaught exception when selecting Administration -> Security menu item
BZ 1141886 - No take snapshot operation schedules for new storage nodes
BZ 1074633 - RFE: Manage storage node snapshots
BZ 1125423 - Fuse Fabric Groups Plugin cannot be enabled
BZ 1144489 - BRMS 6 The original product type discovered for this server was EAP, but the server is now reporting its product type is BRMS
BZ 1074633 - RFE: Manage storage node snapshots
BZ 1144497 - DV6 should not report Product Name as EAP
BZ 1125423 - Fuse Fabric Groups Plugin cannot be enabled
BZ 1146583 - "Ignore" button is disabled always under "Discovery Queue"
BZ 1122444 - Server responds with 204 even if it fails to find the schedule upon POST /metric/data/raw request
BZ 1122444 - Server responds with 204 even if it fails to find the schedule
Merge pull request #104 from lzoubek/bugs/1122444
BZ 1029409 - Auto-enable ejb3 statistics when a user requests calltime metrics for EJBs
BZ 1029409 - Auto-enable ejb3 statistics when a user requests calltime metrics for EJBs
BZ 1144146 - Messaging queue and subscriber runtime is not exposed
BZ 1133601 - New UI theme does not look properly in IE 9
BZ 1025812 - Changing of Queue configuration requires to set expiry queue
BZ 1149766 - Number of child resources retrieved using REST can't be modified using ps param and is always limited to 100
BZ 1148408 - Do not refresh resource tree after scheduling operation
BZ 1025812 - Changing of Queue configuration requires to set expiry queue
BZ 1145031 - Managed Component's error triangle should be more visible
fix TemplatedComponentTest failure - mock copy() for ConfigurationDefinition mock
BZ 1141885 - no snapshot created when user does not have access to directory
BZ 1074633 - RFE: Manage storage node snapshots
BZ 1156023 - eap6 It's not possible to change a datasource configuration when the EAP6 is in 'needs a reload' state
BZ 1158516 - Number of platforms retrieved using REST can't be modified using ps param and is always limited to 100
BZ 1139189 - If a server is in 'MAINTENANCE' mode, should be indicated to user on login
Include rhqapi.js as CLI module
BZ 1133590 - Unable to login in to 'Red Hat Access' in IE
BZ 1144035 - DynaGroup Children table is not visible where the 'display resolution' is 1366x768
BZ 1036101 - BRANDING: JON alert email report says "This message was delivered to you by RHQ."
BZ 1162293 - Unable to reverse proxy traffic to JON UI
Merge pull request #146 from lzoubek/master
BZ 1119802 - RFE: Support for resource type name change
Merge pull request #98 from lzoubek/bugs/1119802
Merge branch 'purgepurgepurge' of https://github.com/tsegismont/rhq into tsegismont-purgepurgepurge
BZ 1133590 - Unable to login in to 'Red Hat Access' in IE
BZ 1133590 - Unable to login in to 'Red Hat Access' in IE
Merge branch 'tsegismont-purgepurgepurge'
update rhqapi.js module
BZ 1032039 - JON server cannot restart itself
BZ 1088046 - JON storage node script displays error ./cassandra: numactl: not found
Merge pull request #149 from veithen/sigterm-propagation
BZ 1166640 - Disabling availability metric has no effect
Lukas Krejci <lkrejci@redhat.com> (55):
Increase the height of the bundle creation dialog for patternfly theme.
BZ 1069547 ] Support for API-based bundle handlers
BZ 1069547 ] Wildfly patching by various means
BZ 1069547 ] Fixes
BZ 1119331 ] Handle the jobs potentially left behind after conversion of the avail duration check job into an EJB time.
BZ 1119331 ] Fix a typo in the DB upgrade step
BZ 1095000 ] Don't try to guess web connector's max connections.
BZ 1069547 ] Removing support for patches from the content subsystem
BZ 1095000 ] Fix test failures.
Merge 'origin/master' into bug/1069547
BZ 1069547 ] Removing support code for rollback operation.
BZ 1069547 ] Fixing the wrong schemaSpec number.
BZ 1069547 ] Delete the downloaded files once not needed.
BZ 1069547 ] Separate CliExecutor's concerns.
Merged pull request #80 from metlos/bug/1069547
BZ 1069547 ] Clearing API changes.
BZ 1129091 ] Upgrade the bundled MySQL JDBC driver to a newer version.
BZ 1069547 ] Limit the choice of resource groups and destinations based on the bundle type.
BZ 1069547 ] Fixing the broken change detection when updating bundle types.
BZ 1069547 ] Fix tag manager bean itests. BundleManager is now more strict about destination specifications.
BZ 1129910 ] Fix CL leak in agent plugin & AgentManagement MBean
BZ 1069547 ] Throw UnknownRecipeException instead of overly broad Exception from the WildflyPatchBundleServerPluginComponent#parseRecipe().
BZ 1069547 ] Add support for patching Host controllers.
BZ 1029102 ] StorageNode's prepareForBootstrap operation returns success message.
BZ 955816 ] Ask server for last known metric val if not known otherwise.
Some small updates.
Runtime config aware configuration timestamp computation.
Merged pull request from #41 from jerr/BZ1100998
Merged pull request #112 from jfclere/master
BZ 1136996 ] Support resource upgrade callback during resource upgrade.
BZ 1135034BZ 1135107 Disallow patching on unsupported EAP versions.
BZ 1127377 ] Log the recoverable error condition at DEBUG rather than WARN
BZ 1069547 ] Add support for patching host controller using bundle handover
BZ 1069547 ] Support shutdown of domain controller in ServerControl
BZ 1136996 ] Call the update lock of disc. callbacks a better name.
BZ 1135034 ] Only fill the upgrade report when needed to reduce traffic.
BZ 955816 ] Don't update the cache with the retrieved value
BZ 955816 ] Added API difference record to client-api.
BZ 1144514 ] No need to remove non-deployed property files from bundle temporary location before deployment.
BZ 1141982 ] Readonly required props with defaults forced to same values during bundle deployment.
BZ 1136945 ] Purge/revert of EAP patch bundles works more sanely.
BZ 1069547 ] Adding "Active Patches" trait to Host ctl & Standalone svr
BZ 1140578 ] Change the patch name delimiter also on the agent-side.
BZ 1136998 ] Fix the logic in the upgrade delegate.
BZ 1069547 ] Fix AS7 plugin itests.
BZ 873471 ] - Correctly resolve relative paths against not-yet existing deploy dirs.
BZ 1069547 ] Only allow single destination to apply patches to server
BZ 1069547 ] Tweak revert and purge behavior to better handle group membership changes.
BZ 1069547 ] Patches no longer deployable through bundle handover.
BZ 1143050 ] Work around the CL leak in Posgres JDBC driver.
BZ 1070521 ] Fixed retrieval of OOB datapoints.
Make the test link for forced OOB calculation work again.
Deprecating the measurement aggregate JPA entity classes. They're no longer used anywhere.
Revert "BZ 1070521 Fixed retrieval of OOB datapoints."
BZ 1070521 ] Fixed retrieval of OOB datapoints.
Michael Burman <miburman@redhat.com> (49):
BZ 1080157 ] Ignore empty values in rhq-storage.properties
BZ 1118063 ] Add unit test to check for proper ResourceKey parsing
BZ 1120411 ] Only allow selecting a proper jdbc driver in the datasource configuration
BZ 1112240 ] Remove pidfile detection from rhqctl and use rhq-agent-wrapper.sh / rhq-server.sh to do the logic of shutting down if necessary
BZ 1117829 ] Add quotes around necessary tableNames and columnNames to force case-sensitivity on PostgreSQL
BZ 1117830 ] Parse nullable from NULLABLE instead of IS_NULLABLE
BZ 1095970 ] Reapplying patch to fix incorrect sequence name
Add missing closetag
BZ 1128003 ] Abort installation if there is an error during the rhq.ear installation
BZ 1131495 ] Refactor SSHInstallUtility to catch error messages and throw exceptions if operations fail, instead of returning just Failed text
BZ 1074636 ] Add ability to move storage datafiles from the StorageNode Administration
Remove dead layout code
BZ 1130091 ] Redirect debug output to a file to let rhqctl continue starting agent
BZ 1129294 ] After successful command, hide the connection information window
BZ 1130162 ] Allow uninstallation to occur with installPath, like stop/start operations. If name is provided, use that information to verify information like before.
BZ 1070981 ] Use both title and data for autofit
Fix copyright information
Refactor all RegExp EmailValidators to a single class
BZ 1129294 ] Message for Start Agent had changed name
BZ 1130162 ] Add intentional-changes for the remote-interface
BZ 1130162 ] Change format of the intentional-api-changes..
BZ 1063382 ] Drop potential stale connection so authenticationFailure is catched correctly to force reinstall of schema
BZ 1129294 ] BZ 1128782 Change destroy() to markForDestroy() to avoid possible Global Uncaught exceptions..
BZ 1139542 ] Change newFactory() to newInstance() to support IBM JDK 1.6
BZ 1139780 ] UndoTasks are done in reverse order, so add stop command after the delete command to the undoTask list
BZ 980084 ] Add stricter email validation regexp to alert-email serverplugin. Use the same regexp as with other EmailValidations
BZ 1142984 ] Fix parsing of output from help --commands
BZ 1136751 ] If drift definition's interval is set to a lower value than agent's interval, show resource error
BZ 1144467 ] BZ 1144477 Boolean with null value is a bad idea, if we could not find the port, then we could not check if the agent was running either, so setting it to default false.
BZ 970784 ] After successful deployment, initiate discovery scan for affected resources on the agent side.
BZ 1146138 ] Add metrics from the Datastax driver, and remove some duplicate internal ones.
BZ 1108095 ] Updating topology delta will automatically change requestLimit. RequestLimit is no longer allowed to be edited directly
Fix MBean method names
BZ 1108095 ] Use topologyDelta instead of hard requestLimit for tests
BZ 970784 ] Fix GUE on new deployments
BZ 1128779 ] Add vertical scrollbar to the listGrid if it does not fit the window
BZ 1112733 ] Define expressionScope baseResource to the option-source
BZ 1139820 ] Remove one useless exception className from the error message from all Bundle related exceptions
Fix if clause, instanceof always returns false is object is null
Fix equals method to check correct class
BZ 1120816 ] Change resource detail badgelogo to one with availability info
BZ 1139735 ] Storage node schema version should not be attempted to upgrade in case of clean installation
BZ 1136751 ] For each iteration of DriftDetector, run all the available drift schedules
BZ 1098243 ] BZ 1149342 When encountering a timeout on StorageSession, recreate RateLimiter with higher warmup time.
BZ 1162182 ] Add support for btrfs, zfs and f2fs
BZ 1127481 ] Add mount options as traits to the filesystem monitoring
Stop enforcing only 1.7.x JDK, allow compiling with 1.7 and newer
BZ 1155822 ] Validate that pid is a numeric value
Add missing null check for recovered property
Michael Burman <yak@iki.fi> (4):
Merge pull request #99 from jfclere/master
Merge pull request #96 from burmanm/BZ1074636
Merge pull request #120 from ppalaga/RHQ-bat2sh
Merge pull request #123 from burmanm/BZ970784
Mike Thompson <mithomps@redhat.com> (7):
BZ 1133739 ] Group OOB portlet link doesn't display graph.
BZ 1033665 ] Add to dashboard does not add multiple charts to default dashboard.
BZ 1030304 ] Incorrect last value in overview graph on resource summary page.
BZ 1153373 ] RHQ fails to do dev startup after new install on Mac OS/X . I fixed the rhq-agent* scripts as these are the minimal changes to make a rhq install work. Any more changes represent risk especially at this late stage in JON release.
BZ 1095508 MacOS - rhq-cli.sh script command fails with 'readlink: illegal option – f'
BZ 1095508 MacOS - rhq-cli.sh script command fails with 'readlink: illegal option – f'. Remove some commented out lines.
BZ 1158948 rhqctl start on solaris 10 shows error- Cannot find the RHQ Agent start script. Provide an alternative on OS/X for $() syntax as solaris doesnt like it even if it is not in the evaluated conditional path (Solaris parses the whole script).
Mike Thompson <mtho11@users.noreply.github.com> (1):
Merge pull request #115 from tsegismont/calltime_daterangeeditor
Peter Palaga <ppalaga@redhat.com> (2):
Support starting the maven build from a directory distinct from rhq root directory
The *nix rhqctl script should mention rhq-server-env.sh rather than rhq-server-env.bat
Simeon Pinder <spinder@redhat.com> (55):
Merge pull request #108 from loleary/loleary/bug/1124767/master
BZ 1124614 ] a few extra changes still needed. - reset serialization id so we don't break serialization with existing agents. - update agent Version -> agent Build usages. - update i18n doc and key as well for Buld vs. Version - fix small npe issue during failure conditions.
BZ 1084890 ] modify CLI and Agent text to reflect update information if available.
BZ 1124614 ] Api justification for ProductInfo changes.
BZ 1124614 ] a few more fixes to merge this change in: - fix erroneous comments no longer needed. - update unit test for AgentSupportedBuildTest checking.
Merge pull request #129 from tsegismont/bug/1038317
BZ 1078546 ] Relax remote client version check so that patched but non-breaking api changes accepted.
BZ 1081564 ] Update rhq ui to support patch update increments when available."
Modify jboss-as-dmr-client to be patchable.
Add support for incremental pom versioning for dependencies.
Update rhq-core-domain for independent versioning as well.
A few more updates for independent versioning of rhq-core-domain as used in many places. - user project.parent.version instead as this will not change.
Update rhq-enterprise-jar for independent versioning.
A few more updates for rhq-core-native-system and version documentation.
Updare rhq-core-plugin-api for independent versioning.
Update rhq-core-util for independent versioning.
Modify rhq-remoting-client-api for independent versioning.
A few more changes for rhq-remoting-client-api.
Missed two references for rhq-core-util independent versioning.
Root pom should still use project.version
Add independent versioning for script and platform modules.
Update test code to be more flexible in test artifact resolution.
Modify rhq-installer-util, rhq-server-control and rhq-server-metrics for independent versioning.
Increment module versions for productization and Update 02.
Modify rhq-database-plugin and rhq-postgres-plugin for independent versioning.
Explicitly set artifact versions for maven-dependency-plugin usages with org.rhq.
Update project.version usages from rhq-container.build.xml
Remove project.version instances from modules.xml instances to support independent versioning.
Adding independent versioning for rhq-core-plugin-container and rhq-arquillian-agent-plugin-container-embedded.
Adding version identifier to root pom.
Adding independent versioning for rhq-core-client-api and rhq-jmx-plugin.
Attempt to fix itest failures by addressing dependency version missMatches.
Adding support for independendent versioning for rhq-remoting-war.
Adding independent versioning for rhq-core-dbutils.
Missed two independent version changes for rhq-core-client-api and rhq-jmx-plugin.
Second attempt to fix intermittent itest failures.
BZ 1115069,1115081 bumping ems version to address issues with components.
BZ 1084890 ] also need to update the VersionPrompt response to support Update versions.
Add support for independent version for rhq-data-migration.
Fix some itest dependency resolution issues.
Missed one more part of rhq-core-client-api dependency.
Fix more itest dependency resolution issues.
Itests still not resolving the correct dependencies. Another fix. - updated Abstract classes to consistently use the same properties - update plugin container itests to check before going to classpath.
Merge issue with previous itest update.
Add independent versioning support rhq-cassandra-plugin.
Attempting to fix test dependency issue.
Fix merge issue with module version updates.
Remove extra version component from merge.
A few more productization fixes: - set the rhq.pom.version. - reset all component versions to be same as project.version. - remove patched eap component incorrectly cherry-picked from 3.2 line.
Revert " Merge issue with previous itest update."
Reset patch module versioning.
Adding support for cumulative patch independent version property to the release scripts.
Adding missing jgroups property.
Merge branch 'spinder/prodfixes'
BZ 962886 ] throw console errors when LDAP server is enabled, but not reachable.
Stefan Negrea <snegrea@redhat.com> (64):
Merge pull request #88 from jsanda/cassandra-1.2.18-upgrade
BZ 1070262 ] Add a custom obfuscation vault that will decode obfuscated property values on fly before passing them to the jboss modules and services.
BZ 1070262 ] Add on-fly preferences obfuscation for agent properties. This done with an annotation for all the agent configuration constants.
BZ 1070262 ] Update the installer to allow vault type obfuscation for properties.
BZ 1070262 ] Rename the new custom vault to PropertyObfuscationVault to correctly represent the intent.
BZ 1070262 ] Agent configuration upgrade to force obfuscation of passwords.
BZ 1070262 ] Move the obfuscated preferences override to the util package so it can be used by the server too.
BZ 1070262 ] Update method documenation since there is only one vault allowed for the entire server.
BZ 1070262 ] Add obfuscation for server preferences.
BZ 1070262 ] Refactor the custom vault to use the picketbox obfuscator. Also, try to fallback in case the property is vaulted but not obfuscated by user.
BZ 1070262 ] Use a restricted pattern for all the obfuscated preferences to be able to distinguish from regularly obfuscated preferences.
BZ 1070262 ] Add unit tests for the obfuscation preferences override class.
BZ 1070262 ] Add restricted formatting extraction to the vault in case the property is stored just as the preferences value.
BZ 1070262 ] Rename method parameters to match the intent for the custom vault implementation.
BZ 1070262 ] Extract just default value in case the property is in a restricted format already.
BZ 1070262 ] Update the password encoding utility to have the original database password property as the default and also adjust the output based on the property.
BZ 1070262 ] Add some missing properties to the server constants to mark them for default obfuscation.
BZ 1070262 ] Make 'restricted' keyword case insensitive for the vault and preferences.
Merge pull request #75 from rhq-project/BZ1070262
Downgrade mysql driver to 5.1.31 to temporarly solve maven mirroring issues.
BZ 1128929 ] Update verbiage to clarify what files need to be updated.
Update the mysql-connector version back to 5.1.32 after JBoss Nexus mirrored repositories got fixed.
BZ 1128929 ] One more revision to clarify that the encode utility can now be used for configuration values in general (not just passwords). Updated the name of the utilities, prompts, and command arguments to activate the feature.
BZ 1096923 ] Enhance the vault detection code to avoid a timing issue on install for the first read attempt. This update also improves the granularity of the log and error messages.
Increase the RHQ Storage startup wait time to 12.5 seconds to be above the default Cassandra superuser setup delay of 10 seconds.
BZ 998673 997667] Updated the time-unit for thread related resouces to include the exact units accepted by EAP.
BZ 1128921 ] Avoid logging the output from the rhq-encode-value utility to the installer log.
BZ 1016585 ] Print warning message when status is requested but no services installed. This situation by itself should not change the exit status of the command but the user should be warned.
BZ 1018938 ] Removing superfluous server bin files. These files are just placeholders but they are not needed since they do not predate the rhqctl work. Only placeholders for control scripts that existed prior rhqctl are required.
BZ 1070299 ] Added auto-start description from the EAP 6 documentation. The functionality for auto-strart field was already correct, just adding field description to avoid confusion.
BZ 1126410 ] Update data migrator to use the latest storage node schema.
BZ 1126410 ] Minor updates based on code review.
Merge pull request #125 from rhq-project/datamigrator
BZ 1084056 ] Added missing policy to the "Anty Entropy Sessions" type (a single bean) to allow users to configure the behaviour of a missing resourece after a Cassandra or Storage Node server restart
BZ 1075575 ] Update C* dependency to a JBoss specific version that has the OpenJDK warning removed.
BZ 1070262 ] Updates to the configuration upgrade code for the server and the agent.
BZ 1075575 ] Upgrade the C* driver to a version that depends only on C* server version 1.2.18-jboss-1.
BZ 1070262 ] Snip superfluous "public" access modifier.
BZ 1070262 ] Obfuscate properties in agent-configuration.xml when the file originates from older agents.
BZ 1070262 ] Few more changes to the agent config update to allow the agent to continue with the startup procedure even if there is an error in the obfuscation attempt.
BZ 1148186 ] Use eval to execute the RHQ agent start command. It was incorrectly sourced in the current script. Note that only config and full config were affected. Also, adjusted the order for defining and export RHQ home to allow proper overrides int RHQ environment script.
BZ 1082805 ] Simplify the upgrade options for the data migration. Only allow to run the data migration. For a fine control over the upgrade process prompt the users to the migration tool directly.
BZ 1082805 ] Simplify the upgrade options for the data migration. Remove more undeeded code.
BZ 1148186 ] More updates for the initial commit: 1) Only assign the pwd to RHQ_AGENT_HOME not already defined 2) Use a temp variable to extract pwd before dirname
BZ 1148186 ] One more update to the initial commit:
BZ 997667 ] A few more updates the plugin descriptor to make the keepalive-time defintion consistent accross all resources.
BZ 1150624 ] Avoid DTD retrieval even if the DOM has it. Also avoid parsing logic to determine if the dtd is on the document; let the transformer handle that at output time.
BZ 1150624 ] Add additional code to prevent attempts to load DTD.
BZ 1070262 ] Fix agent packaging to set the picketbox version for ant-run.xml script via maven pom; remove unused dom4j and commons-httpclient libraries.
BZ 1158892 ] Remove AllEndpointStates property of FailureDetector service from the plugin descriptor. This will prevent a high curn of configuration changes for the service due to the ever changing nature of the property. The property is not needed at this point by any functionality in the Cassandra or Storage Node plugins.
BZ 1070262 ] Adding one missed property to the list of @RESTRICTED properties for the agent configuration file.
BZ 1161806 ] Fix the slice being wrongly computed after a DST transition. If the duration of the time slice is more than one hour, account for the timezone offset and adjust the time slice start time. This will address the issue where the query for time slice data was not returning data due to the a skewed start time.
BZ 1161806 ] Switch the entire server metrics code to use an UTC timezone in all the code. This will avoid any DST issues since there is no DST in UTC timezone. Also, this will avoid any problems due to having an HA environment where the servers are distributed in different timezones.
BZ 1161806 ] Shift the timeslice to a correct UTC timeslice during the index migration. This will gurantee that during metrics index updates the new indexes have slices based on UTC timezone.
BZ 1161806 ] Fix broken unit tests due to timeslice shift to UTC timezone based.
BZ 1161806 ] Update the migration code to handle cases where the data spans a DST change. Without this change, the code will not be able to properly retreive indexes that if the start date is before the DST transition and end date is after the DST transition.
BZ 1070262 ] Added all the tomcat password related properties to the ServerConfigurationConstants file and the upgrade code. Both of these should be pickedup by the upgrade and usage code automatically.
BZ 1130392 ] Fix failing test due to logic change when the actual disk files does not exist.
Fix reactor order and remove circular dependencies issues.
BZ 1166383 ] Add API change exception for ServiceContainerConfigurationConstants.DEFAULT_CONNECTOR_TRANSPORT_PARAMS.
Correct apache ant exclusion for ant-bundle module.
Remove scope definition from pom.
Fix static versioning via property. This is not supported via the current build tools. Update the property to use a known maven property globally defined.
Fix db versioning discrepancy within a single release cycle by re-numbering db-upgrade steps.
Thomas Segismont <tsegismo@redhat.com> (75):
Reuse BatchIterator in GroupAlertDefinitionManagerBean
BZ 1115146 - Purge (delete) data using smaller batches
BZ 1122514 - Query Resource only available in postgres Plugin
BZ 1115146 - Purge (delete) data using smaller batches
BZ 1115725 - Operation history continues to grow unbound with no easy way to purge old history
BZ 1050014 - Cannot deploy bundle to EAP domain mode
itests-2: fix org.rhq.enterprise.server.alert.GroupAlertDefinitionManagerBeanTest.testBug738799
Merge pull request #93 from jfclere/master
Fix AlertConditionTest timing issues for rhq-master-ora build
itests-2: added PurgeOOBTest
BZ 908795 - RFE The JMX plugin should be able to use JBoss Remoting 3 to connect to EAP6 using JSR-160 remoting
BZ 1124845 - EAP6 with secured management - confusing error msg when incorrect Truststore Type is set
BZ 1096332 - All content-related workflows broken on Agent
BZ 1096332 - All content-related workflows broken on Agent
JON3-7 doc: do not confuse EAP server group and bundle destination resource group
This reverts commit 8668677a01100d22e6799ce3f73f58b92a1b030c and 82fba05c62d5a5036455fa936cfa045f60b4724c
BZ 1096332 - All content-related workflows broken on Agent
BZ 1128614 - RHQ 4.12 high CPU usage in hibernate thread (java.util.regex.Pattern$Start.match)
BZ 1096332 - All content-related workflows broken on Agent
JMX Plugin tests enhancements
BZ 1126047 - Agent awaits shutdown of ProcessExecutor idle worker thread; should terminate immediately
BZ 1127411 - WARN Thread-6 (rhq.core.pc.plugin.PluginClassLoader)- Failed to purge embedded jars directory. Cause: java.io.IOException
BZ 1127413 + Bug 1127412
BZ 1127410 - WARN ResourceDiscoveryComponent.invoker.daemon-10 (org.rhq.plugins.postgres.PostgresDiscoveryComponent)- PostgreSQL data directory (/var/lib/pgsql/data) does not exist or is not readable
BZ 999494 - Import child Resource: jboss as (both eap 4 and 5) are not being imported to inventory list after successful import operation
BZ 1032054 - Refresh button on Monitoring/Calltime page does not move 'last 8 hour' time range
BZ 1135678 - AS5 plugin: resources backed by ManagedComponentComponent may stay down indefinitely
BZ 1135551 - bundle deployment handover fails when app runtime name != war name
BZ 1066947 - Alert being triggered twice if the Operation Execution has the status set to In Progress
BZ 1132952 - Process and some other platform services are not listed under group creation dialog search filter
BZ 1032054 - Refresh button on Monitoring/Calltime page does not move 'last 8 hour' time range
BZ 1115146 - Purge (delete) data using smaller batches
Merge branch 'bug/1136996+1135034+1135107' of github.com:metlos/rhq into metlos-bug/1136996+1135034+1135107
BZ 1139607 - EAP cli script fails always during bundle deployment to domain server
Merge pull request #116 from metlos/bug/955816
BZ 1139684 - eap cli script does not get correct result code for eap domain server on windows
BZ 1139287 - branding some files does not have Red Hat copyright headers
BZ 1079303 - Excessive database size when using bundles causing UI to fail
BZ 1062789 - Set quoting to enabled for newly created script server resources
BZ 885848 - Changing WAR/EAR deployment from exploded to unexploded (or vice versa) results in resource always being DOWN/Unavailable
BZ 1032054 - Refresh button on Monitoring/Calltime page does not move 'last 8 hour' time range
BZ 1141839 - EAP6 resource stays UP in resource tree after its configuration directory was moved
BZ 1139684 - eap cli script does not get correct result code for eap domain server on windows
BZ 1140578 - eap6 patching applying patches via bundles fails for Windows - wrong file path extracted
BZ 1135473 - Implicit Variables for CLI are not available if the script is run as notification on an alert
BZ 1145195 - Bundle destination view: deployments table shows partial results and purge button is disabled even if there is a live deployment
Minor changes wrt logging in StorageNodeManagerBean
BZ 1038317 - Use of remote client API results in error/warning messages regarding indirectly referenced JPA annotations not being resolvable
BZ 1077744 - statement timeout during drift purge job
BZ 1146611 - Cannot discover EAP6.0.1: supportsMatching method fails with IllegalArgumentException
Revert "Bug 1146611 - Cannot discover EAP6.0.1: supportsMatching method fails with IllegalArgumentException"
BZ 1146611 - Cannot discover EAP6.0.1: supportsMatching method fails with IllegalArgumentException
BZ 1140676 - Exception logged while inventorying EAP 6 host controller after setting http-interface
BZ 1147001 - Server log exception when saving a resource error
BZ 1005426 - Better CLI Parsing and Error reporting
BZ 1004977 - Datasource configuration changes SHOULD NOT require a complete reload/restart of EAP
BZ 1139735 - There is no way how to upgrade HA environment having two servers each with a co-located storage node when C* schema changes are included
BZ 1139735 - There is no way how to upgrade HA environment having two servers each with a co-located storage node when C* schema changes are included
I broke something in VersionedRuntimeDiscovery. Reverting the change.
BZ 1099447 - as7 It's not possible to add a port to SocketBindingGroup resource
itests-2 were broken beacuse Server and StorageNode entities now have a version column
Fix core domain tests and server itests when database does not have Server and StorageNode version columns
Fix server itests-2 : when creating a Storage Node or a Server as part of an itest, set the version column
Move purge settings to a new "Advanced Purge Settings" group (hidden by default)
BZ 1145776 - RHQ_PARTITION_EVENT data not purged automatically
BZ 1139433 - Deadlock in deletion of RHQ_RESOURCE_ERROR, possibly in resource upgrade?
BZ 1139433 - Deadlock in deletion of RHQ_RESOURCE_ERROR, possibly in resource upgrade?
BZ 1145778 - Purge RHQ_RESOURCE_ERROR table as well
BZ 1131726 - Data from RHQ_CONFIG_UPDATE never purged
Merge pull request #140 from genman/bug/1135136
Merge pull request #138 from genman/bug/1145292
BZ 1154678 - EAP6 - Newly created datasource is not enabled even when you have set Enabled=true – user should be at least warned
BZ 1154678 - EAP6 - Newly created datasource is not enabled even when you have set Enabled=true – user should be at least warned
Merge pull request #139 from genman/bug/1130392
Merge pull request #141 from genman/bug/1130341
burmanm <miburman@redhat.com> (15):
BZ 1079368 ] updateConfiguration follows the same convention as createResource
BZ 1038728 ] BZ 782915 Add required DOCTYPE declaration back, but do not use it on indenting phase
BZ 782915 ] Add support for importing agent configuration files without existing DOCTYPE declaration
BZ 1069855 ] Force CASSANDRA_INCLUDE environment variable to prevent rhqctl from starting wrong Cassandra instance
BZ 1069855 ] Force CASSANDRA_HOME in Windows environments to prevent starting wrong Cassandra instance from rhqctl
BZ 1059444 ] Add attempted hostname to the port in use error messsage
BZ 1118063 ] Use resourceKey as columnFamilyname on operations and set SimpleValue name when discovering columnFamily resources
Fix NPE when ENABLED_ATTRIBUTE is not set
BZ 1120411 ] Datasources
should not be tested like a datasource
BZ 1120411 ] Fix the integration tests and move selection from profile to managed
BZ 1079368 ] Fix potential NPE in nullable column
BZ 1117299 ] Add missing negation from connection pool selection
BZ 837449 ] Change behaviour of apache plugin to select ServerName + VirtualHost combination as first priority for resourceName and fall back to server address only if ServerName can not be found
BZ 1117449 ] Add logging to NativeSystemInfo to detect why Java platform was selected
BZ 1003211 ] Adds automatic recovery information to the alerts if there's a recovery alert fired.